department-of-veterans-affairs / abd-vro

To get Veterans benefits in minutes, VRO software uses health evidence data to help fast track disability claims.
Other
19 stars 6 forks source link

add application monitoring for svc-bip-api #3064

Closed lisac closed 3 months ago

lisac commented 4 months ago

Summary

Introduces MetricLoggerService, which exposes methods for submitting count and distribution metrics via a Datadog API client; and modifies BipApiService and a secondary error handling classes to invoke those metric submission methods.

The data points are submitted under these metric names:

Associated tickets or Slack threads:

Datadog example code:

github-actions[bot] commented 4 months ago

Test Results

114 tests  +5   114 :white_check_mark: +5   34s :stopwatch: -1s  34 suites +1     0 :zzz: ±0   34 files   +1     0 :x: ±0 

Results for commit 1105a6f2. ± Comparison against base commit a4f75bd8.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

JaCoCo Test Coverage

Overall Project 68.61% -2.15% :x:
Files changed 84.81% :green_apple:


File Coverage
BipApiService.java 99.84% :green_apple:
BipRequestErrorHandler.java 88.73% :green_apple:
MetricLoggerService.java 82.61% -17.39% :green_apple:
InvalidPayloadRejectingFatalExceptionStrategy.java 0% -51.56% :x:
github-actions[bot] commented 4 months ago

Test Results

116 tests  +7   116 :white_check_mark: +7   49s :stopwatch: +14s  34 suites +1     0 :zzz: ±0   34 files   +1     0 :x: ±0 

Results for commit 6539eb46. ± Comparison against base commit cc5d7aaf.

:recycle: This comment has been updated with latest results.