department-of-veterans-affairs / abd-vro

To get Veterans benefits in minutes, VRO software uses health evidence data to help fast track disability claims.
Other
19 stars 6 forks source link

Update dev-tools Dockerfile to install AWS CLI #3073

Closed Ponnia-M closed 3 months ago

Ponnia-M commented 3 months ago

Updated dev-tools Dockerfile to install AWS CLI in order to implement specific AWS metrics to our RDS database using AWS Parameters.

Associated tickets or Slack threads:

How does this fix it?[^1]

AWS CLI has been successfully installed in the dev-tool pod.

How to test this PR

Screenshot 2024-06-11 at 2 08 14 PM
github-actions[bot] commented 3 months ago

Test Results

109 tests  ±0   109 :white_check_mark: ±0   32s :stopwatch: -2s  33 suites ±0     0 :zzz: ±0   33 files   ±0     0 :x: ±0 

Results for commit 21ad7f59. ± Comparison against base commit 6d5e3485.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

JaCoCo Test Coverage

Overall Project 66.18% :x:

There is no coverage information present for the Files changed

Ponnia-M commented 3 months ago

@lisac Thanks for this input and it was very helpful. I have pushed another change that installs groff packages that fixes this issue. I tested this out locally and I'm able to run aws help as well as other commands. For additional context, aws configure hasn't been set up yet and this is the next step after these changes are merged. Let me know if this new change works on your end.

lisac commented 3 months ago

Confirming that after a docker build with the latest change, the aws commands continue to work for me locally. haven't tested it out in the dev environment, but i think your addition of groff should address my question, and low risk to deploy. PR approved!