Rewrite lookup table files to improve readability

lukey-luke commented 3 months ago

What was the problem?

This PR rewrites the lookup table for the Contention Classification to use a single .csv file per request of product management.
This PR updates the lookup tables classes in lookup_table.py to return a dict containing keys "classification_code" and "classification_name" in order to get access to both pieces of information at the same time

Associated tickets or Slack threads:

https://github.com/department-of-veterans-affairs/vagov-claim-classification/issues/476

How does this fix it?[^1]

Design provided a new format for a .csv file. This PR uses ContentionTextLookupTable to parse the new .csv

How to test this PR

manual testing of /classifier and /vagov-claim-classifier
run pytest

[^1]: Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. [^secrel]: To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline.

github-actions[bot] commented 3 months ago

Test Results

116 tests ±0 116 :white_check_mark: ±0 37s :stopwatch: +3s 34 suites ±0 0 :zzz: ±0 34 files ±0 0 :x: ±0

Results for commit 4f2f54de. ± Comparison against base commit aa3e3006.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

JaCoCo Test Coverage

Overall Project	67.02%	:x:

There is no coverage information present for the Files changed

tyler-spangler6 commented 3 months ago

Should we update the name for the autosuggestion csv file as well? In the data folder it is named with the PACT act release, but in the new master spreadsheet it is named as "Suggested Conditions v[ ]". This also matches Eva's comment in the zenhub ticket regarding file names.

lukey-luke commented 3 months ago

Should we update the name for the autosuggestion csv file as well? In the data folder it is named with the PACT act release, but in the new master spreadsheet it is named as "Suggested Conditions v[ ]". This also matches Eva's comment in the zenhub ticket regarding file names.

@tyler-spangler6 I don't recall this from the synchronous conversation we had prior, but I found [Release notes] Auto-suggestions release notes on google drive and added the Suggested Conditions v1.1 Flat tab to abd-vro

department-of-veterans-affairs / abd-vro