department-of-veterans-affairs / abd-vro

To get Veterans benefits in minutes, VRO software uses health evidence data to help fast track disability claims.
Other
17 stars 6 forks source link

Revert "add application monitoring for svc-bip-api (#3064)" #3116

Closed brostk closed 1 week ago

brostk commented 1 week ago

This reverts commit c1363c438b95955c96b8f889f4a75642d05a35f1.

this is a test, DO NOT APPROVE

What was the problem?

Associated tickets or Slack threads:

How does this fix it?[^1]

How to test this PR

[^1]: Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. [^secrel]: To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline.

github-actions[bot] commented 1 week ago

Test Results

109 tests   - 7   109 :white_check_mark:  - 7   33s :stopwatch: -3s  33 suites  - 1     0 :zzz: ±0   33 files    - 1     0 :x: ±0 

Results for commit 3c91ee2f. ± Comparison against base commit 31115b9d.

This pull request removes 7 tests. ``` gov.va.vro.bip.service.MetricLoggerServiceTest ‑ getTagsForSubmission() gov.va.vro.bip.service.MetricLoggerServiceTest ‑ getTagsForSubmissionNoCustomTags() gov.va.vro.bip.service.MetricLoggerServiceTest ‑ testCreateDistributionPointsPayload() gov.va.vro.bip.service.MetricLoggerServiceTest ‑ testCreateMetricsPayload() gov.va.vro.bip.service.MetricLoggerServiceTest ‑ testGetElapsedTimeInMilliseconds() gov.va.vro.bip.service.MetricLoggerServiceTest ‑ testGetFullMetricString() gov.va.vro.bip.service.MetricLoggerServiceTest ‑ testGetTimestamp() ```
github-actions[bot] commented 1 week ago

JaCoCo Test Coverage

Overall Project 65.31% :x:
File Coverage
BipApiService.java 99.79% :green_apple:
BipRequestErrorHandler.java 81.95% :green_apple:
InvalidPayloadRejectingFatalExceptionStrategy.java 0% :green_apple: