Closed brostk closed 1 week ago
github-actions[bot]
commented
1 week ago 116 tests ±0 116 :white_check_mark: ±0 35s :stopwatch: -1s 34 suites ±0 0 :zzz: ±0 34 files ±0 0 :x: ±0
Results for commit 1078dba0. ± Comparison against base commit 31115b9d.
github-actions[bot]
commented
1 week ago | Overall Project | 67.77% -0.44% |
:x: |
|---|---|---|
| Files changed | 74.29% | :x: |
| File | Coverage | |
|---|---|---|
| IMetricLoggerService.java | 100% | :green_apple: |
| BipApiService.java | 99.84% | :green_apple: |
| BipRequestErrorHandler.java | 88.12% | :green_apple: |
| MetricLoggerService.java | 68.44% | :green_apple: |
| InvalidPayloadRejectingFatalExceptionStrategy.java | 0% | :green_apple: |
| NoopMetricLoggerService.java | 0% | :x: |
What was the problem?
ep-merge application e2e tests have been failing since a recent update to metric logging within svc-bip-api. This PR is an attempt to clean up the spring implementation and add environmental support to omit metric logging in local/test regions where the services are not configured to perform metric logging.
Associated tickets or Slack threads:
3114
How does this fix it?[^1]
We're now building multiple MetricLoggers or initializing the DataDogConfiguration only once, and we're now only setting up metric logging in non-local/test environments.
How to test this PR
[^1]: Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. [^secrel]: To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline.