department-of-veterans-affairs / abd-vro

To get Veterans benefits in minutes, VRO software uses health evidence data to help fast track disability claims.
Other
17 stars 6 forks source link

Copy of Resolve ArgoCD sync issues on svc-bip-api #3122

Closed meganhicks closed 1 week ago

meganhicks commented 1 week ago

User Story

As a VRO engineer, I would like to be able to use ArgoCD for VRO deployments. As a first step: I would like to be able to use ArgoCD to deploy svc-bip-api to environments dev, qa, and sandbox with minimal manual intervention.

Notes about work This has been partially configured. See ArgoCD (must be on CAG) and va-abd-rrd-argocd-applications-vault.
What needs to be worked through:

This ticket targets Problems 1 and 2.

Recommendations

Acceptance Criteria

(in the scope of environments dev, qa, and sandbox; this does NOT apply to higher environments)

  1. Sync capability, at least one of these: a. Auto-sync is working: when the develop branch of repo va-abd-rrd-argocd-applications-vault is changed, ArgoCD executes a deployment b. Sync is working: when a user clicks the “Sync” button in the ArgoCD UI, ArgoCD executes a deployment
  2. Following an ArgoCD deployment of svc-bip-api, a non-ArgoCD deployment of is successful
  3. Spot checks show that deployments from ArgoCD and non-ArgoCD can be run interchangeably with outcomes of successful deployments, assuming the deployments are not running concurrently. (why: to ensure we don't have to cutover to using strictly ArgoCD deployments; for flexibility while we gain experience with ArgoCD)
  4. The ArgoCD UI displays basic info (eg version of the code, status) of what's currently deployed to the respective environments, even if the most recent deployment was not via ArgoCD; or if that will be too complex to achieve, then documentation on what the ArgoCD UI displays if the most recent deployment was conducted not using ArgoCD
  5. Environments beyond non-production tier are NOT affected

Not included in this work

Related This is a follow up to the deployment improvement workshop (recap) , https://github.com/department-of-veterans-affairs/abd-vro/issues/2781 , and https://github.com/department-of-veterans-affairs/abd-vro/issues/2608 (includes link to the Tech Spec).