department-of-veterans-affairs / abd-vro

To get Veterans benefits in minutes, VRO software uses health evidence data to help fast track disability claims.
Other
17 stars 6 forks source link

EP Merge: Fix metric publishing for contention type codes for cfi. #3133

Closed dfitchett closed 5 days ago

dfitchett commented 1 week ago

What was the problem?

Contention type code for contentions on a claim for increase are shown as INC, not INCREASE. This bug is resulting in no metrics being published for contentions of type increase.

Associated tickets or Slack threads:

How does this fix it?[^1]

Check is modified to compare against INC vs INCREASE

How to test this PR

[^1]: Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. [^secrel]: To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline.

github-actions[bot] commented 1 week ago

Test Results

116 tests  ±0   116 :white_check_mark: ±0   37s :stopwatch: ±0s  34 suites ±0     0 :zzz: ±0   34 files   ±0     0 :x: ±0 

Results for commit 582fbcab. ± Comparison against base commit e3086bbd.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

JaCoCo Test Coverage

Overall Project 67.56% :x:

There is no coverage information present for the Files changed