department-of-veterans-affairs / abd-vro

To get Veterans benefits in minutes, VRO software uses health evidence data to help fast track disability claims.
Other
19 stars 6 forks source link

removed camel library references, update package names and dependencies #3171

Closed chengjie8 closed 1 month ago

chengjie8 commented 2 months ago

What was the problem?

Associated tickets or Slack threads:

How does this fix it?[^1]

How to test this PR

[^1]: Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. [^secrel]: To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline.

github-actions[bot] commented 1 month ago

Test Results

105 tests   - 11   105 :white_check_mark:  - 11   19s :stopwatch: -15s  32 suites  -  2     0 :zzz: ± 0   32 files    -  2     0 :x: ± 0 

Results for commit cc71e3d7. ± Comparison against base commit e7e722a3.

This pull request removes 13 and adds 2 tests. Note that renamed tests count towards both. ``` gov.va.vro.controller.xample.v3.XampleControllerTest ‑ testGetResource() gov.va.vro.controller.xample.v3.XampleControllerTest ‑ testGetResourceWithErrorStatus() gov.va.vro.controller.xample.v3.XampleControllerTest ‑ testGetResourceWithException() gov.va.vro.controller.xample.v3.XampleControllerTest ‑ testGetResourceWithUnknownId() gov.va.vro.controller.xample.v3.XampleControllerTest ‑ testPostResource() gov.va.vro.controller.xample.v3.XampleControllerTest ‑ testPostResourceWithErrorStatus() gov.va.vro.controller.xample.v3.XampleControllerTest ‑ testPostResourceWithException() gov.va.vro.routes.xample.BieXampleRoutesTest ‑ testMainRouteOnException() gov.va.vro.routes.xample.BieXampleRoutesTest ‑ testSaveContentionEventRoute() gov.va.vro.routes.xample.DbHelperTest ‑ testSaveToDb() … ``` ``` gov.va.vro.routes.xample.BieXampleRoutesTest ‑ handleMessage_ExceptionThrown() gov.va.vro.routes.xample.BieXampleRoutesTest ‑ handleMessage_SuccessfulProcessing() ```

:recycle: This comment has been updated with latest results.

msnwatson commented 1 month ago

Really big change list, so I'm hoping we can mostly rely on testing through deployments to lower environments to confirm everything is all good

lisac commented 1 month ago

argh, one of the required CI checks is failing, this one: CI / lint-and-test / test-java. @chengjie8 would you have time to take a look at this? I can take a look, too - have it running locally and was able to reproduce the CI failure - just let me know.

The CI failure:

* What went wrong:
Execution failed for task ':domain-xample:xample-workflows:jacocoTestCoverageVerification'.
> Rule violated for bundle xample-workflows: instructions covered ratio is 0.6, but expected minimum is 0.8
github-actions[bot] commented 1 month ago

JaCoCo Test Coverage

Overall Project 70.43% -1.6% :x:
Files changed 51.06% :x:


File Coverage
DbHelper.java 100% :green_apple:
BieXampleRoutes.java 91.67% -8.33% :green_apple:
RabbitMqConstants.java 0% :x:
MessageQueueConfiguration.java 0% -16.38% :x:
RequestAndMerge.java 0% :green_apple:
ProcessorUtils.java 0% :green_apple:
InOnlySyncProcessor.java 0% :green_apple:
FunctionProcessor.java 0% :green_apple: