search

department-of-veterans-affairs / abd-vro

To get Veterans benefits in minutes, VRO software uses health evidence data to help fast track disability claims.
Other
20 stars 6 forks source link

adjust mock-bgs-api Dockerfile #3194

Closed lisac closed 3 months ago

lisac commented 3 months ago

What was the problem?

mock-bgs-api container is failing to start up in CI runs.

Snippet from the logs suggest an error encountered executing the Dockerfile:

2024-07-12T21:54:48.8975877Z Dockerfile:13
2024-07-12T21:54:48.8976253Z --------------------
2024-07-12T21:54:48.8976831Z   11 |     RUN adduser --no-create-home --disabled-password tron
2024-07-12T21:54:48.8977155Z   12 |     
2024-07-12T21:54:48.8977625Z   13 | >>> RUN chmod a+x /*.sh  && chown -R tron /
2024-07-12T21:54:48.8977948Z   14 |     
2024-07-12T21:54:48.8978289Z   15 |     USER tron
2024-07-12T21:54:48.8978647Z --------------------
2024-07-12T21:54:48.8979743Z ERROR: failed to solve: process "/bin/sh -c chmod a+x /*.sh  && chown -R tron /" did not complete successfully: exit code: 1
2024-07-12T21:54:48.8979760Z 
2024-07-12T21:54:48.8980175Z FAILURE: Build failed with an exception.
2024-07-12T21:54:48.8980181Z 
2024-07-12T21:54:48.8980532Z * What went wrong:
2024-07-12T21:54:48.8981025Z Execution failed for task ':mock-bgs-api:docker'.
2024-07-12T21:54:48.8981605Z > Process 'command 'docker'' finished with non-zero exit value 1

How does this fix it?[^1]

The Dockerfile in question was adjusted in recent PR #3169, as part of other changes.

https://github.com/department-of-veterans-affairs/abd-vro/pull/3169/files#diff-95b28342727462e48b1337997edc60b6db06ea906e8431cd33cc5e0493e2a6ec

This PR reverts the edits to the Dockerfile.

This container is NOT run in the production environment; if it starts up and runs sufficiently to allow CI tests to pass, I propose the risk of negative side effects is low.

How to test this PR

github-actions[bot] commented 3 months ago

Test Results

116 tests  ±0   116 :white_check_mark: ±0   35s :stopwatch: -1s  34 suites ±0     0 :zzz: ±0   34 files   ±0     0 :x: ±0 

Results for commit 20ebb7b1. ± Comparison against base commit ecdbbbd7.

github-actions[bot] commented 3 months ago

JaCoCo Test Coverage

Overall Project 67.02% :x:

There is no coverage information present for the Files changed