Closed dfitchett closed 1 month ago
116 tests ±0 116 :white_check_mark: ±0 36s :stopwatch: -1s 34 suites ±0 0 :zzz: ±0 34 files ±0 0 :x: ±0
Results for commit 307a29e9. ± Comparison against base commit 14b51af3.
:recycle: This comment has been updated with latest results.
Overall Project | 67.02% | :x: |
---|
There is no coverage information present for the Files changed
What was the problem?
There was a race condition present in the job runner upon startup that would allow the program to accept new jobs before resuming current jobs in progress, leading to the same job being worked on by two different threads. See associated ticket for more information.
Associated tickets or Slack threads:
3208
How does this fix it?[^1]
Makes job runner wait for resumed jobs to complete. Also makes it part of the health check so that new jobs cannot be submitted while working on in-progress jobs at startup.
How to test this PR
pytest
pytest ./integration
export BIP_CLAIM_URL=mock-bip-claims-api:20300
COMPOSE_PROFILES=“all” ./gradlew dockerComposeUp
COMPOSE_PROFILES="bip,bgs" ./gradlew -p mocks :dockerComposeUp
./gradlew :domain-ee:ee-ep-merge-app:endToEndTest
[^1]: Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. [^secrel]: To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline.