department-of-veterans-affairs / abd-vro

To get Veterans benefits in minutes, VRO software uses health evidence data to help fast track disability claims.
Other
19 stars 6 forks source link

3224 build image tag array when image already exists for schedule runs #3226

Closed brostk closed 1 month ago

brostk commented 1 month ago

What was the problem?

Scheduled SecRel runs did are not performing scans because images have already been built during the previous PR merge.

Associated tickets or Slack threads:

How does this fix it?[^1]

In the action script, when we find an image which has already been updated, for scheduled runs we will still add the image name and tag to the output list of images used further down the SecRel pipeline.

How to test this PR

[^1]: Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. [^secrel]: To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline.

github-actions[bot] commented 1 month ago

Test Results

116 tests  ±0   116 :white_check_mark: ±0   36s :stopwatch: -1s  34 suites ±0     0 :zzz: ±0   34 files   ±0     0 :x: ±0 

Results for commit a0a53a18. ± Comparison against base commit 4f396adc.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

JaCoCo Test Coverage

Overall Project 67.56% :x:

There is no coverage information present for the Files changed