department-of-veterans-affairs / abd-vro

To get Veterans benefits in minutes, VRO software uses health evidence data to help fast track disability claims.
Other
19 stars 6 forks source link

EP Merge: Abort for ineligible requests #3241

Closed dfitchett closed 1 month ago

dfitchett commented 1 month ago

Summary

Currently, EP Merge does not abort jobs that should have been ineligible from the start. For example, EP Merge will fail in error if the benefit claim type code of the EP400 is anything but 400SUPP. This was noticed in production logs when jobs were failing at the GET_EP400_CLAIM state.

Acceptance Criteria

EP Merge should be updated to include a new ABORTED end state, where any claims that should not be merged due to ineligible criteria:

1 - This is unlikely to happen in any deployed environment, but rather a result of not having a good enough mock service to represent actual data. 2 - This is a mechanism to address the race of EP Merge to begin processing vs the claim being closed elsewhere, bottom line = closed claims are not eligible. 3 - This will only happen if there is a 60 second slow down in the time it takes the claim to have populated contentions, if this is the case the slow down will not be detectable by EP Merge or VRO downstream services, bottom line = No contentions on EP400 means claim is not eligible to merge