department-of-veterans-affairs / abd-vro

To get Veterans benefits in minutes, VRO software uses health evidence data to help fast track disability claims.
Other
19 stars 6 forks source link

discovery: more-accessible argoCD deployment notification to partner teams #3307

Open lisac opened 2 months ago

lisac commented 2 months ago

:warning: note: #3309 should take priority over this discovery ticket. It is very possible that #3309 will in fact address this ticket's concern.

User Story

As an engineer on a partner team running a deployment to dev or qa of my app (eg EP Merge), I would like to be notified when the deployment is completed. I would prefer not to have to log into ArgoCD on the VA network in order to see this notification; and I would prefer for it to be automated.

I understand the ArgoCD auto-sync feature has a default polling period of 3 minutes; however, it would be convenient to get confirmation when the sync is processed.

Acceptance Criteria

  1. Acceptance criteria 1
  2. Acceptance criteria 2
  3. Acceptance criteria 3

Notes about work

To consider: it appears that another tenant has explored Slack notifications; reach out to them for recommendation? https://github.com/department-of-veterans-affairs/lighthouse-benefits-apis-argocd-applications-vault/pull/408 https://github.com/department-of-veterans-affairs/lighthouse-benefits-apis-argocd-applications-vault/pull/412

Another approach might be to configure a Datadog monitor that listens for ArgoCD deployment events - if these are being logged - and pushes notifications to Slack (Datadog->Slack integration).

BerniXiongA6 commented 1 month ago

@BerniXiongA6 let's add this ticket to backlog refinment in Sprint 1