search

department-of-veterans-affairs / acronyms

A list of VA acronyms
45 stars 47 forks source link

Changes to README _only_ won't pass CI #110

Closed goldenmeanie closed 1 year ago

goldenmeanie commented 1 year ago

From #109 Ok, the CI requirements assume that you will be editing acronyms.csv. So as it stands, if you want to edit README.md you need to pair it with some change to the acronyms.csv or it will hang on acronym-lint. This seems like it could be adjusted, but I don't know how. @mchelen

mchelen-gov commented 1 year ago

Here is an attempt to fix this: https://github.com/department-of-veterans-affairs/acronyms/pull/112

mchelen-gov commented 1 year ago

Ok the fix is actually a little more complicated, see https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/troubleshooting-required-status-checks#handling-skipped-but-required-checks

mchelen-gov commented 1 year ago

For simplicity sake, set all tests to run on PRs to master. This should prevent any "Required" checks from stalling. Confirmed working: https://github.com/department-of-veterans-affairs/acronyms/pull/116