feature/appeals-46700 - Githubissues

Return VBMS document directly to Reader on S3 cache miss
Add separate path for reader api call for document to return from vbms directly for s3 miss
update test for new record api fetch
update record fetcher to use parent child for api only fetcher
update test for reader s3 miss and s3 hits
clean up unneeded spec file

Co-authored-by: Andre Pollard andre.pollard@va.govResolves #{efolder issue number} / department-of-veterans-affairs/caseflow#{caseflow issue number} / CASEFLOW-{JIRA number}

Description

Please explain the changes you made here.

Acceptance Criteria

[ ] Code compiles correctly

Testing Plan

Go to ...

[ ] For higher-risk changes: Deploy the custom branch to UAT to test

User Facing Changes

[ ] Screenshots of UI changes added to PR & Original Issue

BEFORE AFTER

Code Documentation Updates

[ ] Add or update code comments at the top of the class, module, and/or component.

Database Changes

Only for Schema Changes

[ ] Timestamps (created_at, updated_at) for new tables
[ ] Column comments updated
[ ] Verify that migrate:rollback works as desired (change supported functions)
[ ] Query profiling performed (eyeball Rails log, check bullet and fasterer output)
[ ] Appropriate indexes added (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
[ ] Add your indexes safely (see Caseflow::Migrations
[ ] DB schema docs updated with make docs (after running make migrate)
[ ] #appeals-schema notified with summary and link to this PR
[ ] Any non-obvious semantics or logic useful for interpreting database data is documented at Caseflow Data Model and Dictionary

Integrations: Adding endpoints for external APIs

[ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
- [ ] Request: Service name, method name, input field names
- [ ] Response: Check expected data structure
[ ] Update Fakes
[ ] Integrations impacting functionality are tested in Caseflow UAT

department-of-veterans-affairs / caseflow-efolder

feature/appeals-46700 #1620