Andre/appeals 46702 2 - Githubissues

Resolves APPEALS_46702

Description

For API calls to eFolder and an S3 cache miss, eFolder would go back to VBMS and get document then store to S3 before returning to Reader. This store to S3 is unnecessary because an ActiveJob is kicked off in Reader when user browses the list of document and caches all the documents. Our update behind a feature flag will return the document and not try to save to S3 for API calls. The ActiveJob will take the existing path and store to S3.

Acceptance Criteria

[ ] Code compiles correctly

Testing Plan

[ ] For higher-risk changes: Deploy the custom branch to UAT to test

User Facing Changes

[ ] Screenshots of UI changes added to PR & Original Issue

BEFORE AFTER

Code Documentation Updates

[ ] Add or update code comments at the top of the class, module, and/or component.

Database Changes

Only for Schema Changes

[ ] Timestamps (created_at, updated_at) for new tables
[ ] Column comments updated
[ ] Verify that migrate:rollback works as desired (change supported functions)
[ ] Query profiling performed (eyeball Rails log, check bullet and fasterer output)
[ ] Appropriate indexes added (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
[ ] Add your indexes safely (see Caseflow::Migrations
[ ] DB schema docs updated with make docs (after running make migrate)
[ ] #appeals-schema notified with summary and link to this PR
[ ] Any non-obvious semantics or logic useful for interpreting database data is documented at Caseflow Data Model and Dictionary

Integrations: Adding endpoints for external APIs

[ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
- [ ] Request: Service name, method name, input field names
- [ ] Response: Check expected data structure
[ ] Update Fakes
[ ] Integrations impacting functionality are tested in Caseflow UAT

department-of-veterans-affairs / caseflow-efolder

Andre/appeals 46702 2 #1624