eFolder Rails 6.1 Rebase Alec k/appeals 46558

AKeyframe commented 1 month ago

Resolves APPEALS-43567 This is a revisit of the work done for APPEALS-28929 - updating eFolder to 6.1 PR

Description

🔴 Warning: Merge & deploy only after APPEALS-43566 has been merged to master. 🔴

Updates Rails to 6.1

pg gem updated for postgres runtime
Fixed depreciated initialization autoloaded constants
Neat / Bourbon removal (required for rails 6.1 upgrade)

Acceptance Criteria

See documentation produced in APPEALS-28920
Perform steps in Rails Upgrade Guide 1.3.1 through 1.5
Address broken tests (if any)
Fix breaking changes introduced by Rails or updated dependencies

Testing Plan

Regression testing via UAT

🔴 Warning: Merge & deploy only after APPEALS-43566 has been merged to master. 🔴

jcroteau commented 1 month ago

🎉 Thanks for addressing my concerns above!

I'll make my final review/approval once https://github.com/department-of-veterans-affairs/caseflow-commons/pull/225 gets merged and the associated ref is updated in Gemfile/Gemfile.lock.

jcroteau commented 1 month ago

📝 Note to self / other reviewers

The following test failures are also present on other eFolder builds; They are not related to the changes in this PR:

Failures:

  1) Backend Error Flows When VBMS returns an error Download with VBMS connection error
     Failure/Error: expect(page).to have_css ".usa-alert-heading", text: "We are having trouble connecting to VBMS"
       expected to find visible css ".usa-alert-heading" with text "We are having trouble connecting to VBMS" but there were no matches. Also found "We could not complete the search for this Veteran ID", which matched the selector but not all filters. 
     # ./spec/features/backend_error_flows_spec.rb:75:in `block (4 levels) in <top (required)>'
     # ./spec/features/backend_error_flows_spec.rb:70:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:37:in `block (2 levels) in <top (required)>'

  2) Backend Error Flows When VVA returns an error Download with VVA connection error
     Failure/Error: expect(page).to have_css ".usa-alert-heading", text: "We are having trouble connecting to VVA"
       expected to find visible css ".usa-alert-heading" with text "We are having trouble connecting to VVA" but there were no matches. Also found "We could not complete the search for this Veteran ID", which matched the selector but not all filters. 
     # ./spec/features/backend_error_flows_spec.rb:97:in `block (4 levels) in <top (required)>'
     # ./spec/features/backend_error_flows_spec.rb:92:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:37:in `block (2 levels) in <top (required)>'

  3) React Downloads Creating a download
     Failure/Error: V2::DownloadManifestJob.perform_later(self, RequestStore[:current_user])

       (V2::DownloadManifestJob (class)).perform_later(#<ManifestSource id: 1, manifest_id: 1, status: "initialized", name: "VBMS", fetched_at: nil, created_at: "2024-07-23 19:28:50.908649000 +0000", updated_at: "2024-07-23 19:28:50.908649000 +0000">, #<User id: 1, css_id: "123123", station_id: "116", email: "test@gmail.com", created_at: "2024-07-23 1...23 19:28:50.735062114 +0000", vva_coachmarks_view_count: 0, participant_id: nil, last_login_at: nil>)
           expected: 2 times with any arguments
           received: 3 times with arguments: (#<ManifestSource id: 1, manifest_id: 1, status: "initialized", name: "VBMS", fetched_at: nil, created_at: "2024-07-23 19:28:50.908649000 +0000", updated_at: "2024-07-23 19:28:50.908649000 +0000">, #<User id: 1, css_id: "123123", station_id: "116", email: "test@gmail.com", created_at: "2024-07-23 1...23 19:28:50.735062114 +0000", vva_coachmarks_view_count: 0, participant_id: nil, last_login_at: nil>)
     # ./app/models/manifest_source.rb:22:in `start!'
     # ./app/models/manifest.rb:34:in `start!'
     # ./app/controllers/api/v2/manifests_controller.rb:16:in `refresh'
     # ------------------
     # --- Caused by: ---
     # Capybara::CapybaraError:
     #   Your application server raised an error - It has been raised in your test code because Capybara.raise_server_errors == true
     #   ./spec/spec_helper.rb:37:in `block (2 levels) in <top (required)>'

Finished in 1 minute 33.23 seconds (files took 3.36 seconds to load)
262 examples, 3 failures, 4 pending

Failed examples:

rspec ./spec/features/backend_error_flows_spec.rb:69 # Backend Error Flows When VBMS returns an error Download with VBMS connection error
rspec ./spec/features/backend_error_flows_spec.rb:91 # Backend Error Flows When VVA returns an error Download with VVA connection error
rspec ./spec/features/react_download_spec.rb:65 # React Downloads Creating a download

department-of-veterans-affairs / caseflow-efolder