department-of-veterans-affairs / caseflow

Caseflow is a web application that enables the tracking and processing of appealed claims at the Board of Veterans' Appeals.
Other
54 stars 19 forks source link

Issues contesting decisions on previous non rating issues show up as rating issues. #10187

Closed shanear closed 5 years ago

shanear commented 5 years ago

In the scenario where a veteran contests a decision on a previous nonrating request issue, the resulting request issue will register as a rating issue instead of a nonrating issue. We should fix this.

Sjones352 commented 5 years ago

@leikkisa can you please provide validation instructions

ghost commented 5 years ago

Validation

Hopefully this works

Check the resulting request issue in the console, and check that it's rating. RequestIssue.find_by(contested_decision_issue_id: 1).rating? RequestIssue.find_by(contested_decision_issue_id: 1).nonrating?

Sjones352 commented 5 years ago

Passes Uat The request issue does not register as a rating issue but a nonrating issue.

Screen Shot 2019-04-19 at 3.38.17 PM.png Screen Shot 2019-04-19 at 3.40.13 PM.png