department-of-veterans-affairs / caseflow

Caseflow is a web application that enables the tracking and processing of appealed claims at the Board of Veterans' Appeals.
Other
54 stars 19 forks source link

Create End Product | Unable to create EP for a Veteran with a Military type address #1378

Closed ghost closed 7 years ago

ghost commented 7 years ago

Description

As a Caseworker when creating an End Product for a Veteran with a Military Type address, I expect to be able to do that.

Environment:

Type of Bug:

Reproduction Steps

Scenario 1 - Creating EP

  1. Go to Dispatch and start Establishing next claim

  2. Click Route Claim

  3. On Create End Product page click Create New EP

  4. Get System Error (see logs below)

Screenshots

Scenario 1 - VBMS Info

screen shot 2017-03-30 at 9 26 49 am screen shot 2017-03-30 at 9 35 50 am

Related Issues

Support Error Message: "Something went wrong on our end: Military Address #118 System error: Unable to move forward: Maybe address issue #127 EP: unable to create: international address #139

Engineering

1277

Vet ID: 516517672S


[certification.cf.uat.ds.va.gov] [9664ddcd-1d67-40ba-b2af-d2a21c226904] [172.30.67.168] [CASEFLOW1 ] [2017-0
3-30 09:29:25 -0400] VBMS HTTP Error 500 (EstablishClaim) <?xml version='1.0' encoding='UTF-8'?><S:Envelope xmlns:env="http://schemas.xmlsoap.org/soap/envelope/" xmlns:S="http://schemas.xmlsoap.org/soap
/envelope/"><env:Header><work:WorkContext xmlns:work="http://oracle.com/weblogic/soap/workarea/">rO0ABXdgAB13ZWJsb2dpYy5hcHAudmJtcy1jbXMtYXBwLmVhcgAAANYAAAAjd2VibG9naWMud29ya2FyZWEuU3RyaW5nV29ya0NvbnRle
HQAEjEyLjEtMjAxNzAzMjgtMTc1MgAA</work:WorkContext></env:Header><S:Body><ns0:Fault xmlns:ns1="http://www.w3.org/2003/05/soap-envelope" xmlns:ns0="http://schemas.xmlsoap.org/soap/envelope/"><faultcode>ns0
:Server</faultcode><faultstring>Error validating ClaimService data input. GUID: a74a27b9-7aea-4a2f-9e01-6609110afa86</faultstring><detail><dataValidationFaultDetailBean xmlns="http://vbms.vba.va.gov/ext
ernal/ClaimService/v4" xmlns:ns0="http://vbms.vba.va.gov/cdm/claim/v4" xmlns:ns1="http://vbms.vba.va.gov/cdm/common/v4" xmlns:ns2="http://vbms.vba.va.gov/cdm/participant/v4"><formFieldErrors xmlns="http
://vbms.vba.va.gov/external/ClaimService/v4"><fieldName xmlns="http://vbms.vba.va.gov/external/ClaimService/v4">PersonalInfo Address City</fieldName><errorType xmlns="http://vbms.vba.va.gov/external/Cla
imService/v4">MINIMUM_LENGTH_NOT_SATISFIED</errorType><message xmlns="http://vbms.vba.va.gov/external/ClaimService/v4">The minimum data length for the PersonalInfo Address City within the veteran was no
t satisfied: The PersonalInfo Address City must not be empty.</message></formFieldErrors><formFieldErrors xmlns="http://vbms.vba.va.gov/external/ClaimService/v4"><fieldName xmlns="http://vbms.vba.va.gov
/external/ClaimService/v4">PersonalInfo Address StateCode</fieldName><errorType xmlns="http://vbms.vba.va.gov/external/ClaimService/v4">MINIMUM_LENGTH_NOT_SATISFIED</errorType><message xmlns="http://vbm
s.vba.va.gov/external/ClaimService/v4">The minimum data length for the PersonalInfo Address StateCode within the veteran was not satisfied: The PersonalInfo Address StateCode must not be empty.</message
></formFieldErrors></dataValidationFaultDetailBean></detail></ns0:Fault></S:Body></S:Envelope>```
mmlumba commented 7 years ago

Sentry related issue: #1461

shanear commented 7 years ago

Figuring out the proper way to do this with the VBMS team

shanear commented 7 years ago

UAT data for a vet with a military address

=> {:address_line1=>"123 KILLPEOPLE STREE", :address_line2=>nil, :address_line3=>nil, :area_number_one=>nil, :area_number_two=>nil, :city=>nil, :competency_decision_type_code=>nil, :country=>"USA", :cp_payment_address_line1=>nil, :cp_payment_address_line2=>nil, :cp_payment_address_line3=>nil, :cp_payment_city=>nil, :cp_payment_country=>nil, :cp_payment_foreign_zip=>nil, :cp_payment_post_office_type_code=>nil, :cp_payment_postal_type_code=>nil, :cp_payment_state=>nil, :cp_payment_zip_code=>nil, :date_of_birth=>"06/22/1980", :debit_card_ind=>"N", :eft_account_number=>nil, :eft_account_type=>nil, :eft_routing_number=>nil, :email_address=>nil, :fiduciary_decision_category_type_code=>nil, :fiduciary_folder_location=>nil, :file_number=>"516517672", :first_name=>"Garba", :foreign_code=>"862", :last_name=>"ARMSTRONG", :middle_name=>nil, :military_post_office_type_code=>"DPO", :military_postal_type_code=>"AE", :org_name=>nil, :org_title=>nil, :org_type=>nil, :phone_number_one=>nil, :phone_number_two=>nil, :phone_type_name_one=>nil, :phone_type_name_two=>nil, :prep_phrase_type=>nil, :province_name=>nil, :ptcpnt_id=>"600161046", :ptcpnt_relationship=>nil, :return_code=>"SHAR 9999", :return_message=>"Records found.", :salutation_name=>nil, :sensitive_level_of_record=>"0", :ssn=>"516517672", :state=>nil, :suffix_name=>nil, :temporary_custodian_indicator=>nil, :territory_name=>nil, :treasury_mailing_address_line1=>"GARBA ARMSTRONG", :treasury_mailing_address_line2=>"123 KILLPEOPLE STREE", :treasury_mailing_address_line3=>"DPO AE", :treasury_mailing_address_line4=>nil, :treasury_mailing_address_line5=>nil, :treasury_mailing_address_line6=>nil, :treasury_payment_address_line1=>nil, :treasury_payment_address_line2=>nil, :treasury_payment_address_line3=>nil, :treasury_payment_address_line4=>nil, :treasury_payment_address_line5=>nil, :treasury_payment_address_line6=>nil, :zip_code=>"20854", :sex=>"M"}
shanear commented 7 years ago

From VBMS:

For military type addresses the type in the establishClaim SOAP request should be 'OVR' regardless of if the address is foreign or not.

The city field should be either APO, FPO, or DPO and the postal code (stateCode) field should be either AA, AE, or AP.

In the VBMS UI validation is done on the Postal Code field for a Military type address so that it should not be empty (as well as the PO and Zip fields).

516517672 in UAT appears to be an edge case as the Postal Code is somehow empty in the VBMS UI. For these types of edge case scenarios I would recommend filing a ticket for the original Production issue by emailing itsc@va.gov. This way the Dev team can respond to original specific issues and not the UAT equivalent as Scott mentioned on the call.

ghost commented 7 years ago

Apparently @wturne 's appeal won't get processed by Caseflow

this is in preprod

123111097S

screen shot 2017-04-17 at 3 55 06 pm
dsva-appeals-certification-preprod/opt/caseflow-certification/src/log/caseflow-certification.out i-00160c68e4e4c1f72-172.30.70.93 [certification.cf.preprod.ds.va.gov] [98445f87-b525-458f-a89d-b4e652631887] [172.30.70.93] [CASEFLOW1 ][2
017-04-17 15:55:24 -0400] status_code=500, body=<?xml version='1.0' encoding='UTF-8'?><S:Envelope xmlns:env="http://schemas.xmlsoap.org/soap/envelope/" xmlns:S="http://schemas.xmlsoap.org/soap/envelope/"><env:Header><work:WorkContext x
mlns:work="http://oracle.com/weblogic/soap/workarea/">rO0ABXeyAB13ZWJsb2dpYy5hcHAudmJtcy1jbXMtYXBwLmVhcgAAANYAAAAjd2VibG9naWMud29ya2FyZWEuU3RyaW5nV29ya0NvbnRleHQAEjEyLjEtMjAxNzA0MDUtMTEzMQAdd2VibG9naWMuYXBwLkNvcnBvcmF0ZURhdGFFQVIAAADWA
AAAI3dlYmxvZ2ljLndvcmthcmVhLlN0cmluZ1dvcmtDb250ZXh0AAYxMC4yLjAAAA==</work:WorkContext></env:Header><S:Body><ns0:Fault xmlns:ns1="http://www.w3.org/2003/05/soap-envelope" xmlns:ns0="http://schemas.xmlsoap.org/soap/envelope/"><faultcode>
ns0:Server</faultcode><faultstring>Error validating ClaimService data input. GUID: 3e142573-d82b-4d58-90ac-2b4b10ca05c1</faultstring><detail><dataValidationFaultDetailBean xmlns="http://vbms.vba.va.gov/external/ClaimService/v4" xmlns:n
s0="http://vbms.vba.va.gov/cdm/claim/v4" xmlns:ns1="http://vbms.vba.va.gov/cdm/common/v4" xmlns:ns2="http://vbms.vba.va.gov/cdm/participant/v4"><formFieldErrors xmlns="http://vbms.vba.va.gov/external/ClaimService/v4"><fieldNamexmlns="h
ttp://vbms.vba.va.gov/external/ClaimService/v4">PersonalInfo Address City</fieldName><errorType xmlns="http://vbms.vba.va.gov/external/ClaimService/v4">MINIMUM_LENGTH_NOT_SATISFIED</errorType><message xmlns="http://vbms.vba.va.gov/exte
rnal/ClaimService/v4">The minimum data length for the PersonalInfo Address City within the veteran was not satisfied: The PersonalInfo Address City must not be empty.</message></formFieldErrors><formFieldErrors xmlns="http://vbms.vba.v
a.gov/external/ClaimService/v4"><fieldName xmlns="http://vbms.vba.va.gov/external/ClaimService/v4">PersonalInfo Address StateCode</fieldName><errorType xmlns="http://vbms.vba.va.gov/external/ClaimService/v4">MINIMUM_LENGTH_NOT_SATISFIE
D</errorType><message xmlns="http://vbms.vba.va.gov/external/ClaimService/v4">The minimum data length forthe PersonalInfo Address StateCode within the veteran was not satisfied: The PersonalInfo Address StateCode must notbe empty.</mes
sage></formFieldErrors></dataValidationFaultDetailBean></detail></ns0:Fault></S:Body></S:Envelope>, request=#<VBMS::Requests::EstablishClaim:0x00559df4fcd018 @veteran_record={:file_number=>"123111097", :sex=>"M", :first_name=>"Brandon"
, :last_name=>"James", :ssn=>"123111097", :address_line1=>"PSC 3 BOX 1234", :address_line2=>nil, :address_line3=>nil, :city=>nil, :state=>nil, :country=>"USA", :zip_code=>"96266", :address_type=>""}, @claim={:benefit_type_code=>"1", :p
ayee_code=>"00", :predischarge=>false, :claim_type=>"Claim", :end_product_modifier=>"172", :end_product_code=>"172BVAG", :end_product_label=>"BVA Grant", :station_of_jurisdiction=>"397", :date=>Sat, 15 Apr 2017, :suppress_acknowledgeme
nt_letter=>false, :gulf_war_registry=>false}>
ghost commented 7 years ago

PASSED

screen shot 2017-04-19 at 1 46 43 pm

IT WORKS!

screen shot 2017-04-19 at 2 15 04 pm screen shot 2017-04-19 at 2 15 42 pm