department-of-veterans-affairs / caseflow

Caseflow is a web application that enables the tracking and processing of appealed claims at the Board of Veterans' Appeals.
Other
54 stars 19 forks source link

Get POA information from BGS [5] #1710

Closed amprokop closed 7 years ago

amprokop commented 7 years ago

We should fetch POA information using BGS.

This is a complex issue that will likely take awhile to get right. The dev should feel free to adjust requirements, second-guess this ticket description, etc.

VetRecordService will give us a POA code for a single Veteran, which we need cross reference with a list of POA names and types cached to get the human-readable name and type of the organization.

findPOAs on StandardDataWebService returns a list of all organizations that represent Veterans. We should cache this in Redis with a TTL of 24 hours, and use the cached POA list to cross-reference with the code.

We should start by using ruby-bgs to make manual requests to verify the endpoints we need and the information that comes from them.

We should only make the BGS requests for the POA list on UAT for now.

Get BGS documentation from Alex and Shane.

image

Acceptance Criteria: BGS POA info should populate Certification fields on the Confirm Case Details page.

Steps to reproduce:

amprokop commented 7 years ago

This is blocked on validating until alexis and artem have BGS accounts, but we can start development.

amprokop commented 7 years ago

Anya will do the ruby bgs issue, another dev might do the Caseflow integration.

amprokop commented 7 years ago

This issue needs to be updated with new info.

amprokop commented 7 years ago

Work closely with @amprokop on this. Blocked until @shellicious adds updated mocks and details.

msknee commented 7 years ago

From a conversation with @shanear, @nicholasholtz, @amprokop, and @laurjpeterson, we've determined that BGS is not an accurate source of information about the representative.

Assumptions resulting from conversations:

cc @cmgiven, who had thoughts in the VA design meeting today.

Open questions:

Mocks:

Mismatching info, 2 column layout of VBMS/VACOLS info:

new poa flow mismatching 1

User selects "None of the above" bc both VBMS/VACOLS info is wrong.

new poa flow mismatching 2

User selects "Service organization" and sees a searchable/scrollable dropdown of service orgs. They are able to select "Unlisted service org" as one of the dropdown choices.

new poa flow mismatching 3

User selects "Other" and is reminded to update name/contact info manually in VACOLS.

new poa flow mismatching 4

User selects "Attorney". How should this, and "Agent", behave?

new poa flow mismatching 5

Variation of mismatching flow, with VBMS/VACOLS info displayed as a table. I personally slightly prefer this one because it's cleaner.

new poa flow table

Possible confirmation page if VBMS/VACOLS info matches. It feels strange to make the user click through a page that only has a success message on it. I'm very open to skipping the "Confirm Case Details" step if VBMS/VACOLS info matches, and take the user straight to "Confirm Hearing".

new poa flow happy path

cmgiven commented 7 years ago

"Other" is the POA 0.6% of the time.

My note was that at some point, Caseflow will have to become the authoritative source of truth for POA, because it will be the only system that can associate POA on a per-issue basis. Rather than asking users to select a single POA, when in fact there could be multiple POAs, perhaps this will push us to assume responsibility for authoritative POA information.

shanear commented 7 years ago

@cmgiven What do you think about this statement for now:

We assume that if an appeal has multiple representatives (different reps for different issues), that is has already been split into different appeals by the time certification happens. If an appeal with multiple reps makes it this far, we think that users should cancel the certification and split up the appeal, then certify the appeals separately.

cmgiven commented 7 years ago

That's news to me. VBA is splitting appeals with multiple reps? Has that been common practice? It seems counterproductive, as they'll just be merged back on the Board side.

shanear commented 7 years ago

According to @nicholasholtz and another attorney who I can't remember her name, yes. They also won't be merged back, this is the practice that the Board uses as well.

shanear commented 7 years ago

@shellicious A couple other assumptions we picked up that weren't listed:

1) The main problem is the VACOLS PoA being incorrect. VBMS can be assumed to be correct, since they are diligent to update VBMS with a new 21-22 form. This was confirmed by several attorneys.

2) It's much less risky and technically difficult to update VACOLS than it is to update BGS. If we accidentally update BGS with the wrong PoA it can cause lots of problems. I don't think we should touch it.

3) If the VACOLS and BGS PoA's are not the same, they will have to look at the most recent 21-22 or 21-22a to figure out whether a) the VACOLS PoA is wrong because it wasn't updated correctly, or b) the appeal truly has a different PoA from their normal PoA.

Because of the above assumptions, I think we should provide the following scenarios:

amprokop commented 7 years ago

@cmgiven @shanear — the other attorney was Brianne Ogilvie. And yes, from our discussions, those appeals do not get merged back together, the only way to support multiple POAs is with multiple VACOLS appeals.

amprokop commented 7 years ago

@shellicious — Agree that the page as written looks strange, but maybe that's because we're not showing details on the page. Didn't we specifically add a documents check success page? Is this different in some other way?

nicholasholtz commented 7 years ago

Sent these questions to Christa Schriber, the attorney who runs the OGC Accreditation database:

• Is there a requirement that attorneys, agents, and VSOs keep their address updated to maintain accreditation? We are looking for a source of truth for representative contact information. • Who maintains control of database on the IT side? • Do you know if it is possible to obtain access to the underlying data? Am I correct in my assumption that there would be no PII concerns, since the database search is public. • Looking at the Excel file extract, I saw 18,000+ names; is that an accurate count of accredited attorneys and agents? How often is it updated? And generally, how often are new submissions received?

nicholasholtz commented 7 years ago

Christa responded:

• Is there a requirement that attorneys, agents, and VSOs keep their address updated to maintain accreditation?

We are looking for a source of truth for representative contact information. Attorneys and Claims Agents are required to send in statements of good standing (every year) and proof of their Continuing Legal Education requirements (every other year) so our addresses for active attorneys and claims agents are pretty accurate. We are working on revising our regulations to expressly state that they must update their addresses with our office within 30 days of a change. Also, the Data Governance Council (Susan Sullivan) is heading a VA-wide project that would identify OGC as the primary source for all contact information for representatives.

• Who maintains control of database on the IT side?

Randy Trexler and Charlotte Price

• Do you know if it is possible to obtain access to the underlying data?

Yes, I believe that we can give other offices access if there is a business reason that would require the access. Other IT systems also query our staging server so that they can stream our information into their system (e.g., EBenefits allows you to select a representative based off of information that has been streamed from OGC’s database).

• Am I correct in my assumption that there would be no PII concerns, since the database search is public.

It depends. If you are directly accessing our GCLAWS database, there are privacy concerns because all of the information that is included in our database is not public. If you are querying our staging server, which preps the info to go public, I doubt there are privacy concerns.

• Looking at the Excel file extract, I saw 18,000+ names; is that an accurate count of accredited attorneys and agents? How often is it updated? And generally, how often are new submissions received?

Our list for claims agents is accurate and updated nightly. Our list of accredited attorney includes everyone that is accredited but the list hasn’t been purged in a while. We are in the process of suspending all the attorneys that are delinquent on their CLE requirements so by the end of the year that list should be accurate too. Also, not sure if it would be helpful but we are also hooked up with gov.delivery which is a emailing services that allows us to send mass emails to all representative to update them on initiatives (e.g., we could send out an email telling everyone to make sure that their address on OGC’s public facing webpage is correct.)

She also provided an IT proposal requesting a new database for the accreditation program, but not including it here right now until I can be sure about contracting issues.

@amprokop - figure you are going to like this stuff!

msknee commented 7 years ago

Design changes I'm gonna make:

Remaining open questions (@amprokop, @cmgiven, @nicholasholtz, @shanear, your thoughts welcome here! I will also ask this of designers in tmrw's design sync):

Changes to explore for a future release:

shanear commented 7 years ago

Updating either system will be technically challenging and fraught with edge cases. I propose we break this down into two iterations:

Iteration 1

Iteration 2

If they are different, give the user the option to update VACOLS with the information from VBMS. There are some issues with this however.