search

department-of-veterans-affairs / caseflow

Caseflow is a web application that enables the tracking and processing of appealed claims at the Board of Veterans' Appeals.
Other
54 stars 18 forks source link

Reader | Welcome gate #1999

Closed gnakm closed 7 years ago

gnakm commented 7 years ago

Description

This is operation, "Let's get rid of URL hack!" Currently users have to type in the Veteran ID number in the URL in order to access Reader. Let's give them a better experience!

AC

Welcome message

Table

Mockup

image

Note: Work assignments

Copy

NOTE - copy below is more accurate than copy in the mock!

Title: Welcome to Reader!

Body: Reader allows attorneys and judges to review and annotate Veteran claims folders. Learn more about Reader on our Help page.

Related Story

https://github.com/department-of-veterans-affairs/caseflow/issues/2342

gnakm commented 7 years ago

Can we get the FAQ in for Milestone 2? What will be the requirement for entering ID?

gnakm commented 7 years ago

Previous AC:

Description

Currently (for the pilot) users have to type in the Veteran ID number in the URL in order to access Reader. This is prone to error and quite frankly, annoying. Let's give them a better experience!

Operation let's get rid of URL hack!

AC

Mockup

image

gnakm commented 7 years ago

@mdbenjam Could we show users what cases they've already opened vs. new ones that came in? Trying to understand the level of complexity this may entail.

image

mdbenjam commented 7 years ago

@gnakm I think that's doable. We'd have to create new DB entries, but that could lead to some interesting data so I think it's worth doing.

mdbenjam commented 7 years ago

Two notes.

  1. To the dev who works on this: I'll have a DasRepository merged today that you can use to get the current cases assigned to a user.
  2. @gnakm I think it's best to remove the issue/number of documents columns for now. The issues should be easy to add. I can work on that when I get back from the offsite. The number of documents should probably wait until we've integrated with eFolder Express.
gnakm commented 7 years ago

@mdbenjam Sounds good.

Dropping this here for future: image

abbyraskinUSDS commented 7 years ago

@gnakm i can't capitalize Attorney/Judge. it hurts my soul too much. This means the mock copy is slightly different from the copy description -- i added a note.

abbyraskinUSDS commented 7 years ago

also, I can take point on updating FAQs with @wturne. 😄

abbyraskinUSDS commented 7 years ago

@mdbenjam to what extent does including the search functionality here increase the scope of this ticket (is it something we can reuse from another application?)? i'm wondering if we should break it out as its own ticket or if you think it makes sense to develop all of this at once. (given interaction, potential errors, etc.)

gnakm commented 7 years ago

@abbyraskin I vote that we make a separate issue for the top as well. I beefed up the AC for the search part at the top.

@mdbenjam Also, could you tell me some use cases of errors for searching ID number? The :tumbler_glass: Check list told me to check in with you about this 😛 image

nicholasholtz commented 7 years ago

For the copy, you might be better off going with "claims folder" rather than "case file". That is the language people use, anyway. But I defer to all of you wise folks.

abbyraskinUSDS commented 7 years ago

Thanks, let's go with that if @gnakm is okay with it! (I think I've had "c-file" engrained in me since my very formative eFolder Express days.)

It looks like the AC could use a little updating in general, as we removed some of the columns. I will tidy it up and post the old AC here. (note there will be small copy changes that differ from mocks @mdbenjam)

abbyraskinUSDS commented 7 years ago

(Old AC for reference)

Description

This is operation, "Let's get rid of URL hack!" Currently users have to type in the Veteran ID number in the URL in order to access Reader. Let's give them a better experience!

AC

Welcome message

Search

Table

Mockup

image

Copy

NOTE - copy below is more accurate than copy in the mock!

Title: Welcome to Reader!

Body: Reader allows attorneys and judges to review and annotate Veteran case files. Search for a Veteran ID below to get started.

Learn more about Reader on our FAQ page.

abbyraskinUSDS commented 7 years ago

Search story tracked in https://github.com/department-of-veterans-affairs/caseflow/issues/2342

gnakm commented 7 years ago

@mdbenjam Sorry for getting back to you late on the button width. I added this to the AC above - Width of "new" button should match "continue" button. Basically the padding on the button is correct according to style guide but I'm going to add when buttons are STACKED, they should all be same width. It's an exception we're going to have to add.

ghost commented 7 years ago

AC is missing the URL for the welcome page: reader/appeal

Going back from other pages can result in a beautiful JSON:

jsonhistory

mdbenjam commented 7 years ago

JSON is interesting, let me look into that.

ghost commented 7 years ago

Bad time with the header

whatsupwithheader

It's not exactly loading new documents for a different case if the previous one failed

It seems like VACOLS/VBMS has to be forced sometimes

  1. Visit one Document List and have fun
  2. Go back to Appeal List
  3. Visit a Document List with error/no documents
  4. Go back to Appeal List
  5. Go to another Document List
  6. The Document List is not loaded - old "errored" Document List is shown

Bad time with veteran name if you assume that it will be found

https://10.236.66.249/sentry/caseflow-uat/issues/280/

ActionView::Template::Error

undefined method `snamef' for nil:NilClass
mdbenjam commented 7 years ago

Header is a known limitation of doing the page layout in Rails not React. Here is the ticket: https://github.com/department-of-veterans-affairs/caseflow/issues/2422. I'll look into two and three.

mdbenjam commented 7 years ago

Additional error. Tried in Prod and Jane Nicholas couldn't access her cases. There were two reasons for this:

  1. We are not saving VACOLS user ids in our database, but assumed we were. Therefore we were querying with a null user which turned up nothing.
  2. We were looking for when the decision signed date was null, instead we should be looking for when the received date is null.
ghost commented 7 years ago

Show cases in the order of when it was assigned to user (newest on top, oldest on bottom)

How can one tell? Does this even matter? Does the attorney care? Should they just sort by vet name?

If case has already been viewed by that user, show secondary button styling with word "Continue". If case in brand new, show primary button with word "New"

Does not work when using browser's back button:

Only works by clicking the logo. backtoappeals

abbyraskinUSDS commented 7 years ago

@mdbenjam @kierachell I will take out the AC about ordering -- we can explore this in a future enhancement ticket after we test this with users. re: your second point, ideally this would work with the browser's back button as well.

ghost commented 7 years ago

PASSED I guess

nicholasholtz commented 7 years ago

@abbyraskin I know this is closed, but wouldn't the correct order be based on currently-assigned due dates? (which are subject to revision, of course)

abbyraskinUSDS commented 7 years ago

technically it's random for now, but I think that's a good approach.