search

department-of-veterans-affairs / caseflow

Caseflow is a web application that enables the tracking and processing of appealed claims at the Board of Veterans' Appeals.
Other
53 stars 18 forks source link

Strange VACOLS Diary Notes are showing up for Dispatch claims whose EPs that have already been cested #2292

Closed lakohl closed 7 years ago

lakohl commented 7 years ago

AMO contacted @abbyraskin and I this afternoon to let us know that they were seeing odd VACOLS Diary notes show up when they ran the 97 VACOLS report (in transit to ARC but not cested) even though the EPs already had been cested.

'So they had an assistant coach review some of them and he decided on his own the diaries were the reason these cases were showing up on the report.  That' when they decided to start deleting the diaries.' (John subsequently asked them to stop doing this.)

Another strange parts of this is that at least two of the three instances pointed out to us were claims sent by Caseflow Dispatch to be worked at ARC (we don't usually add diary notes for those).

Example of the VACOLS view:

screen shot 2017-06-08 at 4 29 27 pm
lakohl commented 7 years ago

@abbyraskin and I were in a Lync conversation with Amy Chelgreen and John Shrive (AMO) this afternoon, I've excerpted what seem like the most useful parts:

screen shot 2017-06-08 at 6 22 06 pm(answer is yes)

screen shot 2017-06-08 at 6 18 38 pm screen shot 2017-06-08 at 6 23 46 pm screen shot 2017-06-08 at 6 19 18 pm screen shot 2017-06-08 at 6 20 24 pm screen shot 2017-06-08 at 6 20 49 pm screen shot 2017-06-08 at 6 21 03 pm
lakohl commented 7 years ago

@nicholasholtz ^ for awareness

ghost commented 7 years ago

Just processing a good old partial grant. No SIC or anything

[appeals.cf.uat.ds.va.gov] [f835d8a8-7197-4538-9192-4a54a6c9fc9e] [172.30.67.229] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:25:19 -0400]    (105.9ms)            
INSERT into PRIORLOC

(LOCDOUT, LOCDTO, LOCSTTO, LOCSTOUT, LOCKEY)                                                                                                                                                                                                
VALUES

(SYSDATE, SYSDATE, '98', 'RO17', '2734975')                                                                                                                                                                                        
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-090df6af8023312cb-172.30.67.229 [appeals.cf.uat.ds.va.gov] [f835d8a8-7197-4538-9192-4a54a6c9fc9e] [172.30.67.229] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:25:19 -0400] 
FINISHED VACOLS: update_vacols_location! 2734975:   0.020000   0.000000   0.020000 (  0.320106)                                                                                                               
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-090df6af8023312cb-172.30.67.229 [appeals.cf.uat.ds.va.gov] [f835d8a8-7197-4538-9192-4a54a6c9fc9e] [172.30.67.229] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:25:19 -0400] 
STARTED VACOLS: Note.generate_primary_key 2734975                                                                                                                                                             
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-090df6af8023312cb-172.30.67.229 [appeals.cf.uat.ds.va.gov] [f835d8a8-7197-4538-9192-4a54a6c9fc9e] [172.30.67.229] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:25:19 -0400]   SQL (104.4ms)        
SELECT count(*) as count                                                                                                                                                                     
FROM ASSIGN
WHERE TSKTKNM = '2734975'                                                                                                                                                                                                               
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-090df6af8023312cb-172.30.67.229
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-090df6af8023312cb-172.30.67.229 [appeals.cf.uat.ds.va.gov] [f835d8a8-7197-4538-9192-4a54a6c9fc9e] [172.30.67.229] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:25:19 -0400] FINISHED VACOLS: Note.generate_primary_key 2734975:   0.000000   0.000000   0.000000 (  0.104543)
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-090df6af8023312cb-172.30.67.229 [appeals.cf.uat.ds.va.gov] [f835d8a8-7197-4538-9192-4a54a6c9fc9e] [172.30.67.229] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:25:19 -0400] 
STARTED VACOLS: Note.create! '2734975'

dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-090df6af8023312cb-172.30.67.229 [appeals.cf.uat.ds.va.gov] [f835d8a8-7197-4538-9192-4a54a6c9fc9e] [172.30.67.229] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:25:19 -0400]    (104.5ms)        
INSERT into ASSIGN
(TASKNUM, TSKRQACT, TSKSTAT, TSKDTC, TSKCLASS, TSKACTCD, TSKDASSN,
TSKDDUE, TSKTKNM, TSKSTFAS, TSKSTOWN, TSKADUSR, TSKADTM)                                                                                                                                                                                   VALUES                                                                                                                                                                                                                                          
('2734975D35', '--- !ruby/hash:ActionController::Parameters {}

dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-090df6af8023312cb-172.30.67.229 ', 'P', 30, 'ACTIVE', 'BVA30', SYSDATE,                                                                                 TO_TIMESTAMP('2017-07-09 00:25:19:372832','YYYY-MM-DD HH24:MI:SS:FF6'), '2734975', 'RO16', 'RO17', 'RO17', SYSDATE)

dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-090df6af8023312cb-172.30.67.229 [appeals.cf.uat.ds.va.gov] [f835d8a8-7197-4538-9192-4a54a6c9fc9e] [172.30.67.229] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:25:19 -0400] FINISHED VACOLS: Note.create! '2734975':   0.000000   0.000000   0.000000 (  0.104741)
ghost commented 7 years ago

Same for a Remand:

STARTED VACOLS: update_vacols_location! 2719940
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84 [appeals.cf.uat.ds.va.gov] [f147a195-0962-431d-9833-ccf34269be17] [172.30.70.84] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:39:45 -0400]    (104.0ms)            UPDATE BRIEFF                                                                                                                                                                                     
SET BFDLOCIN = SYSDATE,                                                                                                                                                                                                                           
BFCURLOC = '98',                                                                                                                                                                                                                              
BFDLOOUT = SYSDATE,                                                                                                                                                                                                                           
BFORGTIC = NULL                                                                                                                                                                                                                           WHERE BFKEY = '2719940'
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84 [appeals.cf.uat.ds.va.gov] [f147a195-0962-431d-9833-ccf34269be17] [172.30.70.84] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:39:45 -0400]    (103.8ms)            UPDATE PRIORLOC                                                                                                                                                                                   SET LOCDIN = SYSDATE,                                                                                                                                                                                                                             LOCSTRCV = 'RO17',                                                                                                                                                                                                                            LOCEXCEP = 'Y'                                                                                                                                                                                                                            WHERE LOCKEY = '2719940' and LOCDIN is NULL
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84 172.30.66.175 - dsva [08/Jun/2017:20:39:45 -0400] "GET /metrics HTTP/1.0" 200 - 0.0266
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84 [appeals.cf.uat.ds.va.gov] [f147a195-0962-431d-9833-ccf34269be17] [172.30.70.84] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:39:45 -0400]    (102.8ms)            INSERT into PRIORLOC
(LOCDOUT, LOCDTO, LOCSTTO, LOCSTOUT, LOCKEY)
VALUES
(SYSDATE, SYSDATE, '98', 'RO17', '2719940')
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84 [appeals.cf.uat.ds.va.gov] [f147a195-0962-431d-9833-ccf34269be17] [172.30.70.84] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:39:45 -0400] 
FINISHED VACOLS: update_vacols_location! 2719940:   0.020000   0.000000   0.020000 (  0.311094)
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84 [appeals.cf.uat.ds.va.gov] [f147a195-0962-431d-9833-ccf34269be17] [172.30.70.84] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:39:45 -0400] STARTED VACOLS: Note.generate_primary_key 2719940
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84 [appeals.cf.uat.ds.va.gov] [f147a195-0962-431d-9833-ccf34269be17] [172.30.70.84] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:39:46 -0400] SQL (103.3ms)        SELECT count(*) as count                                                                                                                                                                       
FROM ASSIGN                                                                                                                                                                                                                                   
WHERE TSKTKNM = '2719940'                                                                                                                                                                                                               
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84                                                                                                                 
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84 [appeals.cf.uat.ds.va.gov] [f147a195-0962-431d-9833-ccf34269be17] [172.30.70.84] [CASEFLOW_317   caseflow@va.gov] [2017-06-08 20:39:46 -0400] 
FINISHED VACOLS: Note.generate_primary_key 2719940:   0.010000   0.000000   0.010000 (  0.103591)

dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84 [appeals.cf.uat.ds.va.gov] [f147a195-0962-431d-9833-ccf34269be17] [172.30.70.84] [CASEFLOW_317   caseflow@va.gov
] [2017-06-08 20:39:46 -0400] STARTED VACOLS: Note.create! '2719940'

dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84 [appeals.cf.uat.ds.va.gov] [f147a195-0962-431d-9833-ccf34269be17] [172.30.70.84] [CASEFLOW_317   caseflow@va.gov
] [2017-06-08 20:39:46 -0400]    (106.4ms)        INSERT into ASSIGN

(TASKNUM, TSKRQACT, TSKSTAT, TSKDTC, TSKCLASS, TSKACTCD, TSKDASSN,

TSKDDUE, TSKTKNM, TSKSTFAS, TSKSTOWN, TSKADUSR, TSKADTM)

VALUES

('2719940D15', '--- !ruby/hash:ActionController::Parameters {}

dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84 ', 'P', 30, 'ACTIVE', 'BVA30', SYSDATE, TO_TIMESTAMP('2017-07-09 00:39:45:937821','YYYY-MM-DD HH24:MI:SS:FF6'), '2719940', 'RO51', 'RO17', 'RO17', SYSDATE)

dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84 [appeals.cf.uat.ds.va.gov] [f147a195-0962-431d-9833-ccf34269be17] [172.30.70.84] [CASEFLOW_317   caseflow@va.gov
] [2017-06-08 20:39:46 -0400] FINISHED VACOLS: Note.create! '2719940':   0.000000   0.000000   0.000000 (  0.106660)
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-01f161765583edf55-172.30.70.84 [appeals.cf.uat.ds.va.gov] [f147a195-0962-431d-9833-ccf34269be17] [172.30.70.84] [CASEFLOW_317   caseflow@va.gov
] [2017-06-08 20:39:46 -0400]    (3.8ms)  COMMIT

Happens regardless of whether any SIC were selected or not

ghost commented 7 years ago

Earliest ruby/hash note I can find is from April 12th, that's when a lot of stuff got refactored too.

https://github.com/department-of-veterans-affairs/caseflow/blob/8b2702ffc36da0cd1a3de817970db4f6545076bb/app/controllers/establish_claims_controller.rb#L151 Where do these params come from? And if they're " " are they treated as nil?

From parsing isNotePage I see no case when the review stage of the task is ever treated as not a Note page https://github.com/department-of-veterans-affairs/caseflow/blob/ae4a0685d820d5f34b368d5fa362fb2dd60a7f5a/client/app/containers/EstablishClaimPage/EstablishClaim.jsx#L258

but I suck at reading/parsing/comprehending JS code so don't trust me

ghost commented 7 years ago

Stopped getting these notes after the code was merged, yay!

TSKADTM = when note was created, last one I see from smoke tests in on 15th, branch was merged on 16th 👍 

VACOLSfetch(DEVcon, getNotes, "TSKADTM >= TO_DATE('2017-06-12 15:39:00', 'YYYY-MM-DD HH24:MI:SS')")
     TASKNUM                                         TSKRQACT TSKSTAT TSKDTC TSKCLASS TSKACTCD              TSKDASSN               TSKDDUE TSKTKNM TSKSTFAS
1 2734975D40 --- !ruby/hash:ActionController::Parameters {}\n       P     30   ACTIVE    BVA30 2017-06-15 08:50:06.0 2017-07-15 12:50:12.0 2734975     RO16
2 2739290D41 --- !ruby/hash:ActionController::Parameters {}\n       P     30   ACTIVE    BVA30 2017-06-15 08:52:53.0 2017-07-15 12:52:59.0 2739290     RO20
3 2734975D38 --- !ruby/hash:ActionController::Parameters {}\n       P     30   ACTIVE    BVA30 2017-06-13 08:49:15.0 2017-07-13 12:50:25.0 2734975     RO16
4  888111D24 --- !ruby/hash:ActionController::Parameters {}\n       P     30   ACTIVE    BVA30 2017-06-15 08:47:01.0 2017-07-15 12:47:07.0  888111     RO44
5  888111D22 --- !ruby/hash:ActionController::Parameters {}\n       P     30   ACTIVE    BVA30 2017-06-13 08:46:15.0 2017-07-13 12:47:25.0  888111     RO44
6 2739290D39 --- !ruby/hash:ActionController::Parameters {}\n       P     30   ACTIVE    BVA30 2017-06-13 08:51:49.0 2017-07-13 12:52:59.0 2739290     RO20
7  888111D23 --- !ruby/hash:ActionController::Parameters {}\n       P     30   ACTIVE    BVA30 2017-06-14 08:46:29.0 2017-07-14 12:47:46.0  888111     RO44
8 2734975D39 --- !ruby/hash:ActionController::Parameters {}\n       P     30   ACTIVE    BVA30 2017-06-14 08:49:27.0 2017-07-14 12:50:43.0 2734975     RO16
9 2739290D40 --- !ruby/hash:ActionController::Parameters {}\n       P     30   ACTIVE    BVA30 2017-06-14 08:52:16.0 2017-07-14 12:53:33.0 2739290     RO20
  TSKSTOWN TSKADUSR               TSKADTM
1     RO17     RO17 2017-06-15 08:50:06.0
2     RO17     RO17 2017-06-15 08:52:53.0
3     RO17     RO17 2017-06-13 08:49:15.0
4     RO17     RO17 2017-06-15 08:47:01.0
5     RO17     RO17 2017-06-13 08:46:15.0
6     RO17     RO17 2017-06-13 08:51:49.0
7     RO17     RO17 2017-06-14 08:46:29.0
8     RO17     RO17 2017-06-14 08:49:27.0
9     RO17     RO17 2017-06-14 08:52:16.0
ghost commented 7 years ago

PASSSED

FINISHED VACOLS: Note.generate_primary_key 1923398:   0.000000   0.000000   0.000000 (  0.106646)                                                                                                       
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-048f701a493977552-172.30.71.154 [appeals.cf.uat.ds.va.gov] [498c45f1-795d-47c3-8249-ab4988ce97de] [172.30.71.154] [CASEFLOW_317   caseflow@va.gov] [2017-06-17 12:40:29 -0400] STARTED VACOLS: Note.create! '1923398'                                                                                                                                                                  
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-048f701a493977552-172.30.71.154 [appeals.cf.uat.ds.va.gov] [498c45f1-795d-47c3-8249-ab4988ce97de] [172.30.71.154] [CASEFLOW_317   caseflow@va.gov] [2017-06-17 12:40:29 -0400]    (140.5ms)        
INSERT into ASSIGN                                                                                                                                                                          (TASKNUM, TSKRQACT, TSKSTAT, TSKDTC, TSKCLASS, TSKACTCD, TSKDASSN,                                                                                                                                                                          TSKDDUE, TSKTKNM, TSKSTFAS, TSKSTOWN, TSKADUSR, TSKADTM)                                                                                                                                                                                VALUES                                                                                                                                                                                                                                       ('1923398D33', 'The BVA Partial Grant decision dated 06/07/2017 is being transfered from ARC as it contains: Foreign pension, DIC - all other foreign countries in your jurisdiction.', 'P', 30, 'ACTIVE', 'BVA30', SYSDATE,                
TO_TIMESTAMP('2017-07-17 16:40:29:080502','YYYY-MM-DD HH24:MI:SS:FF6'), '1923398', 'RO18', 'RO17', 'RO17', SYSDATE)