department-of-veterans-affairs / caseflow

Caseflow is a web application that enables the tracking and processing of appealed claims at the Board of Veterans' Appeals.
Other
53 stars 18 forks source link

Section 508 Audit | Remediate non-conformant issues (25633) #5110

Closed nikitarockz closed 5 years ago

nikitarockz commented 6 years ago

As Project Manager, I would like the section 508 non-conformant issues that were identified in the test performed on 3/26/2018 on this product so that we are in compliant with our ATO requirements.

Just the Facts

Product Results Environment
Hearing Prep Non-compliant http://dsva-appeals-certification-demo-1715715888.us-gov-west-1.elb.amazonaws.com/test/users

Finding - See Audit Notes

Defect Defect Description Functional Performance Criteria Severity Recommended Resolution Status Comments
1 Text content is not tagged properly for assistive technology users. 1.3.1 Critical Ensure text content is tagged properly for assistive technology users. New See Note 1
2 The name, role, and value of elements cannot be read by assistive technology programs. 4.1.2 Critical Make sure the name, role, and value of all elements can be read by assistive technology programs. New See Note 2
3 A well-defined on-screen indication of the current focus is not provided. 2.4.7 Critical Ensure a well-defined on-screen focus is provided for all elements within the web application. New See Note 3
4 Content cannot be accessed using a keyboard. 2.1.1 Critical Make sure all web elements can be accessed using a keyboard. New See Note 4
5 Content does not have sufficient color contrast to be distinguished by users with visual impairments. 1.4.3 Medium Ensure content has sufficient color contrast to be distinguished by users with visual impairments. New See Note 5
6 Field labels are not read for assistive technology users. 3.3.2 Critical Make sure field labels can be read by assistive technology programs. New See Note 6

Acceptance Criteria

  1. Verify that a Remediation Plan has been provided within 2 weeks.
  2. Verify that these non-conformant issues have/has been reconciled, remediation planned, or justification provided.

Related Issues

Section 508 | Hearing Prep | Request remediation of non-conformant issues (25633) #1930

Engineering Section 508 Audit | Remediate non-conformant issues (25633) #5110

PRs https://github.com/department-of-veterans-affairs/caseflow/pull/5752 https://github.com/department-of-veterans-affairs/caseflow/pull/5694

nikitarockz commented 6 years ago

Audit Notes

**At the direction of the product’s stakeholder, the Audit of March 26, 2018, was conducted on the pilot version of Caseflow at http://dsva-appeals-certification-demo-1715715888.us-gov-west-1.elb.amazonaws.com/test/users. In addition, this audit was conducted using the google Chrome web browser and the Hearing Prep at 283 account setting.

The following examples are not, and should not be interpreted as, an exhaustive or complete list of all instances of a given accessibility defect. Examples were chosen to ease reproduction of the accessibility defect and to illustrate where multiple defects produce additional barriers to accessibility in combination. Stakeholders of the product should conduct internal testing to identify any additional instances of defects identified in this report. However, because these examples list the end-user experience of accessibility defects identified may result from or be explained in terms of multiple accessibility defects.

Note 1, Defect 1:

Headings are not tagged properly for assistive technology users. The following is an example:

Tables that appear visually are not read as tables with assistive technology programs. The following is an example:

Text content presented in tables is not properly tagged for assistive technology users. The following is an example:

Same page links in the Help portion of Caseflow do not function properly. When assistive technology is enabled a user is not taken to the question of the link they activated. Using these links with the keyboard works as intended.

Links are not tagged properly. The following is an example:

The tabbing order is illogical. The following is an example:

Buttons are improperly tagged on the hearing Worksheet page. The following are examples:

PDF documents do not have a title set. The following is an example:

Graphics do not have alternative text descriptions. The following is an example:

Note 2, Defect 2:

The name, role, and value of elements cannot be read by assistive technology. The following are examples: • On the main page an assistive technology user does not know which tab is currently selected. Visually the tab is highlighted so a user knows which tab is currently selected. This defect can also be found on the Hearing Worksheet and Hearing Prep pages. • When a tab is selected, an assistive technology user does not know sub content is generated below the list of tabs that can be activated. Assistive technology users should be alerted that content has been updated. • On the Your Hearing Days page when the Hearing Prep DSUSER menu is activated an assistive technology user does not know content has been expanded and sub menu content is available.

Note 3, Defect 3:

A visual indication of the current focus is lost for assistive technology users. The following are examples: • In the User Selector combo box if a keyboard user scrolls down below the options that appear on screen the screen will not scroll maintaining a visual indication of the current focus. • On the Hearing Worksheet page focus is lost between Rep Name and Witness/Observer.

Note 4, Defect 4:

Buttons are not accessible using a keyboard and assistive technology programs. The following are examples: • On the hearing Worksheet page the Save as PDF button cannot be accessed using a keyboard or with assistive technology programs. This button should be included in the tabbing order. • On the hearing Worksheet page, the Delete button found on the Current Issues tab cannot be accessed with a keyboard or using assistive technology programs.

Note 5, Defect 5:

Content does not have sufficient color contrast to be distinguished by users with visual impairments. The following are examples: • The on-screen visual focus indication has a color contrast ratio of 1.6:1 which does not meet the minimum color contrast ratio of 4.5:1. image

• In the Caseflow hearing Prep Training guide highlighting is used for emphasis of items. The highlighted color has a color contrast ratio of 4.0:1 which does not meet the minimum color contrast ratio of 4.5:1. image

Note 6, Defect 6:

Field labels are not read for assistive technology users. The following are examples: • On the Daily Docket page there are check boxes for Prep and Transcript Requested. Both of these check boxes are read as: label. This defect can also be found with all the check box selections on the hearing Worksheet page. • The field label for Notes is read as: Time/RO(s) Notes. This label should read as Notes as it appears visually for the field. • Combo box labels are not read. Visually the labels read as: Disposition, Hold Open, and AOD. For all 3 of the combo boxes assistive technology reads select…

lakohl commented 6 years ago

cc @annienguyenUSDS

nikitarockz commented 6 years ago

Remediation Plan

All issues will be addressed within 3 sprints. Some will be addressed sooner do to UI design changes.

lakohl commented 6 years ago

@annienguyenUSDS @nikitarockz I believe @nolawi has finished all the tickets related to these issues. Perhaps we should do an internal double-check of these issues and then have the 508 team re-test?

lakohl commented 6 years ago

@annienguyenUSDS when HP demo is stabilized we could ask the 508 team to re-test.

lakohl commented 6 years ago

I made this ticket to update the environments page with instructions for accessing our apps: https://github.com/department-of-veterans-affairs/caseflow/issues/6441 Once it's updated, we'll need to provide that info to the 508 team as well. See https://github.com/department-of-veterans-affairs/appeals-pm/issues/2101

nolawi commented 5 years ago

All the issues for this have been merged and is in production. Closing this now.

nikitarockz commented 5 years ago

Re-opening

All tasks have not been completed.

nicholasholtz commented 5 years ago

@nikitarockz How do we know that all tasks have not been completed? Has this been retested by the VA 508 team? Can you provide more specifics to explain why Nolawi's note of 10/4 is not accurate? Thanks.

nikitarockz commented 5 years ago

@nicholasholtz No this hasn't been retested by the VA 508 Team. When I was going to send it back to VA team to retest, I asked the engineers and they said not all of the changes were implemented. @sharonwarner @Sjones352 Can you ladies add more context?

@sneha-pai I am not sure you were in the room when we were having this conversation but you might have some information as to these fixes being done.

sharonwarner commented 5 years ago

@nikitarockz @nicholasholtz

We have definitely fixed some of these issues, but not all of them. Is it possible to hold off on the retest until after our February deadline? It will take some time to go through and confirm which issues have been corrected.