search

department-of-veterans-affairs / codeql-tools

MIT License
4 stars 2 forks source link

Not set & invalid emass.json settings not causing code health indicator to report a problem #55

Closed Boberski closed 1 year ago

Boberski commented 1 year ago

During a support call this afternoon for https://github.com/department-of-veterans-affairs/ves-redis-lookup-sync-svc

We noticed that in their emass.json file, they had not updated the default system ID, and also had an invalid system name

However, after they had done the other necessary configuration, the code health indicator was green, no problems

While the repo is correctly flagged on the enablement dashboard as there being a problem, and e.g. the error issue is fine,

.. I had thought that invalid emass.json data (invalid system ID) also caused the tool health check to fail?

Boberski commented 1 year ago

I suppose to consolidate from Slack,Michael Boberski 3:02 PM good afternoon, @Brett Logan wanted to call attention to a new issue opened just now https://github.com/department-of-veterans-affairs/codeql-tools/issues/55 thanks in advance for taking a look

Brett Logan 3:10 PM Thanks Mike, I’ll take a look shortly. I can say it’s working as it was designed right now (we don’t validated the data in the pipeline) only on the enablement dashboard. We can change that though, and do the validation in the pipeline as well. I’ll comment on the issue in a few.

Michael Boberski 3:23 PM thanks brett. yes we have identified it as a support problem as a result of the dev support meetings, people ignoring the error issue and email since shows green health. we designed this to upload always as one of the baseline requirements, so leaving code health ok but codeql db's not being uploaded, for system ID of 0, is a bug.. 3:27 btw, how do you reconcile that with https://github.com/orgs/department-of-veterans-affairs/discussions/1 which you and i had written together, that problems with emass.json can cause the health to fail, "The second is potentially caused by invalid data being used in emass.json file settings"

lindluni commented 1 year ago

Addressed in https://github.com/department-of-veterans-affairs/codeql-tools/commit/457ba95d557b92f745d4535407af5abb2affb2b4