department-of-veterans-affairs / connect_vbms

VBMS SOAP API client
Other
17 stars 9 forks source link

Add getDispositions request call #196

Closed kahlouie closed 6 years ago

kahlouie commented 6 years ago

connects #188

kahlouie commented 6 years ago

I'd like to test this against UAT before merging, but at the moment, I'm not sure there are any veterans in UAT that have dispositions. I've sent an email out to Colin to see if we can change that 😃 . Otherwise it's ready for review.

kahlouie commented 6 years ago

Tested claims with one and zero dispositions. Seems okay to merge in now, but I've got a request out to Colin (who is great) for a claim with more than 1 disposition. At least we handle the single case :)

leikkisa commented 6 years ago

Good job on being mindful of checking the zero one and many cases!