department-of-veterans-affairs / connect_vbms

VBMS SOAP API client
Other
17 stars 9 forks source link

Origin source v5 bug #200

Closed leikkisa closed 6 years ago

leikkisa commented 6 years ago

connects https://github.com/department-of-veterans-affairs/caseflow/issues/6251 Fix marshalling error

Tested against UAT with V5 and it worked.

leikkisa commented 6 years ago

I was getting a marshalling error in UAT when trying to make a HigherLevelReview, which would have used V5. I wonder if it's because: xml["cdm"].origSrc "APP" is shorthand?

leikkisa commented 6 years ago

I just tested Kara's code and that worked for me too (which is good! But now I'm confused about what the problem is). I will check that Caseflow is using an updated version of VBMS now.

leikkisa commented 6 years ago

I'm not sure what's causing the marshalling error, but going to close this for now because when I manually tested it, it seems to be fine.