department-of-veterans-affairs / connect_vbms

VBMS SOAP API client
Other
17 stars 9 forks source link

Add same station special issue to update contention #230

Closed leikkisa closed 5 years ago

leikkisa commented 5 years ago

When we update contentions (such as the contention text), we are inadvertently dropping special issues such as same station review or legacy issue opt in.

This PR alone does not fix this problem, because we are also not getting special issues when we fetch contentions from VBMS, and we're only using that data as a basis for the rest of the contention data right now. But this is a pre-requisite to fixing the entire issue.

This has been tested in UAT with both a contention that has special issues, and a contention that does not.

Note - this came about because it's needed for fixing some data where there were manually created contentions in VBMS. (https://github.com/department-of-veterans-affairs/caseflow/issues/11249)