department-of-veterans-affairs / generator-vets-website

Yeoman generator for applications on VA.gov
Creative Commons Zero v1.0 Universal
2 stars 3 forks source link

Refactor form generator to choose 1 or 4 pages #417

Closed rhasselle-oddball closed 3 months ago

rhasselle-oddball commented 3 months ago

image image image image image

image image

rhasselle-oddball commented 3 months ago

I kinda like having the blank template, but this is cool too. Otherwise, everything looks good to me!

@Mottie ty for the feedback. Addressed comments. I think not having a blank is OK. I figure it's easier to change/adjust 1 page with everything already setup correctly with recommend web component patterns, rather than adding it from scratch.

rhasselle-oddball commented 3 months ago

Thanks again for working on this! Do you think any of the platform forms library docs will need to be updated for these changes?

@jamigibbs good call. I created a ticket for updating docs, after we've finished making changes in this repo (there are more coming in the next week)