search

department-of-veterans-affairs / next-build

Front-end templating, build, and deploy for VA.gov CMS content.
Creative Commons Zero v1.0 Universal
9 stars 5 forks source link

PR: remove unused styles #769

Closed ttran-Therisa closed 1 month ago

ttran-Therisa commented 1 month ago

Description

Remove unused style classes following content-build's removal of unused classes

Ticket

Relates to #767. (or closes?)

Developer Task

- [ ] PR submitted against the `main` branch of `next-build`.
- [ ] Link to the issue that this PR addresses (if applicable).
- [ ] Define all changes in your PR and note any changes that could potentially be breaking changes.
- [ ] PR includes steps to test your changes and links to these changes in the Tugboat preview (if applicable).
- [ ] Provided before and after screenshots of your changes (if applicable).
- [ ] Alerted the #accelerated-publishing Slack channel to request a PR review.
- [ ] You understand that once approved, you are responsible for merging your changes into `main`. (Note that changes to `main` will move automatically into production.)

Testing Steps

QA steps

What needs to be checked to prove this works?
Pages to examine

Reviewer

Reviewing a PR

This section lists items that need to be checked or updated when making changes to this repository.

Standard Checks

- [ ] Code Quality: Readabilty, Naming Conventions, Consistency, Reusability
- [ ] Test Coverage: 80% coverage
- [ ] Functionality: Change functions as expected with no additional bugs
- [ ] Performance: Code does not introduce performance issues
- [ ] Documentation: Changes are documented in their respective README.md files
- [ ] Security: Packages have been approved in the TRM

Merging an Approved Layout

When merging a layout, you must ensure that the content type has been turned on for next-build inside the CMS. This CMS flag must be turned on for editors to preview their work using the next build preview server.

Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.

The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.

Merging a Non-Approved Layout

Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the main branch. It is imperative that we do not push anything live that has not been approved.

Ensure that this layout has been added to the templates.md file with the current status of the work.

ttran-Therisa commented 1 month ago

Here is the classes that listed to be removed processed-content 1 file change; wysiwyg/index.tsx authored-by-line 1 file change; personProfile/index.tsx created-line 1 file change; newsStory/index.tsx full-story 1 file change; newsStory/index.tsx local-health-services not found in next-build mental-health-care-phone not found in next-build system-img not found in next-build event-time-zone not found in next build featured-story not found in next build events-show 3 file changes; eventListing/indext.tsx; storyListing/indext.tsx; pressReleaseListing/indext.tsx featured-services not found in next-build field-official-name 1 file change; vetCenter/index.tsx recurrent-event 1 file change; event/index.tsx va-c-list-link-teasers not found in next-build va-c-white-box not found in next-build office-show not found in next-build library-show not found in next-build break-div not found in next-build asset-body-header not found in next-build asset-download-trigger not found in next-build operating-statuses not found in next-build operating-status-info not found in next-build normal-hours not found in next-build emergency-resources not found in next-build