In the effort to clean up our code we need to investigate and remove unused endpoints. This ticket is to take a look at the endpoints under /email-branding/ and remove the ones marked for removal. You can view the table of endpoints here.
User Story(ies)
As an engineer
I want to clean up and reduce our codebase
So that it is easier to maintain and upgrade in the future.
ALL email_branding across all services are null, so it is never hitting the else block in the first image
We will need to hard-code the branding style
Area to hard-code:
Will probably look like:
Engineering Checklist
Please treat this process as a proof of concept to understand how we need to approach each ticket where we are assessing, and potentially removing code/endpoints that are "unused". Keep track of the steps you took so we have a guide for future work. Tread cautiously and keep the team informed of what you learn and decide to make sure we do not risk impacting existing supported notification functionality.
[ ] Investigate the endpoints starting with /email-branding/ to make sure they aren't being used, document your process (high level) so we can reuse it for other endpoint tickets.
[ ] Remove tests associate with those endpoints
[ ] Remove the code associated with those endpoints (if possible). Make sure not to remove any code used by other parts of the application.
[ ] Remove the model(s) associate with this endpoint.
[ ] Hard-code the branding
Acceptance Criteria
When the designated code and tests have been removed, the application retains full functionality.
Steps taken for this ticket are documented
QA Considerations
[ ] The QA Regression Suite passes
[ ] The Cypress regression passes
Potential Dependencies
Make sure the removal of these endpoints doesn't affect the work Strike is doing.
Make sure that our VA branding in emails is not impacted by this
User Story - Business Need
In the effort to clean up our code we need to investigate and remove unused endpoints. This ticket is to take a look at the endpoints under
/email-branding/and remove the ones marked for removal. You can view the table of endpoints here.User Story(ies)
As an engineer I want to clean up and reduce our codebase So that it is easier to maintain and upgrade in the future.
Additional Info and Resources
email_brandingacross all services arenull, so it is never hitting theelseblock in the first imageWill probably look like:
Engineering Checklist
Please treat this process as a proof of concept to understand how we need to approach each ticket where we are assessing, and potentially removing code/endpoints that are "unused". Keep track of the steps you took so we have a guide for future work. Tread cautiously and keep the team informed of what you learn and decide to make sure we do not risk impacting existing supported notification functionality.
/email-branding/to make sure they aren't being used, document your process (high level) so we can reuse it for other endpoint tickets.Acceptance Criteria
QA Considerations
Potential Dependencies