v3 - international SMS - Githubissues

department-of-veterans-affairs / notification-api

Notification API

MIT License

16 stars 9 forks source link

v3 - international SMS #1595

Closed kalbfled closed 2 months ago

kalbfled commented 10 months ago

User Story - Business Need

[ ] Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a Notify service, I want to be able to send international SMS messages So that I can serve all veterans.

Additional Info and Resources

See #1585.

Engineering Checklist

In app/v3/notifications/rest.py::v3_send_notification, add an additional check for permission to send international SMS.
- [ ] Remove the TODO on line 76. That is not the appropriate location.
- [ ] Add a test similar to line 75 in the if "phone_number" in request_data: block (after line 106). If phone_number.country_code != 1, the service must have INTERNATIONAL_SMS_TYPE permission.
[ ] Unit tests

Acceptance Criteria

[ ] New code contains the checks in notification_utils.recipients.get_international_phone_info

kalbfled commented 10 months ago

@mjones-oddball While working on v3 tickets, I discovered that anybody with SMS, but not international SMS, permission can use v3 to send international SMS right now. This is a very easy ticket, and I would like to fix this immediately.