department-of-veterans-affairs / notification-api

Notification API
MIT License
16 stars 9 forks source link

Upgrade protobuf #1886

Closed mchlwellman closed 3 weeks ago

mchlwellman commented 3 months ago

User Story - Business Need

The notification-api container failed to deploy after a dependency upgrade due to issues with protobuf. From the logs it looks like the issue might be with eventlet, but that needs to be investigated.

User Story(ies)

As a VANotify developer
I want the latest version of protobuf
So that we minimize vulnerabilities and future upgrade pains.

Additional Info and Resources

screenshot_cropped

Acceptance Criteria

Potential Dependencies

We should work this in parallel with ddtrace #1662

kbelikova-oddball commented 2 months ago

Hey team! Please add your planning poker estimate with Zenhub @coreycarvalho @cris-oddball @EvanParish @k-macmillan @kalbfled @MackHalliday @mchlwellman

kalbfled commented 2 months ago
$ pip show protobuf
Name: protobuf
Version: 4.25.4
Summary: 
Home-page: https://developers.google.com/protocol-buffers/
Author: protobuf@googlegroups.com
Author-email: protobuf@googlegroups.com
License: 3-Clause BSD License
Location: /.venv/lib/python3.10/site-packages
Requires: 
Required-by: ddtrace, google-api-core, googleapis-common-protos, grpcio-status, proto-plus
EvanParish commented 2 months ago
$ poetry show protobuf 
 name         : protobuf 
 version      : 4.25.4   
 description  :          

required by
 - ddtrace >=3
 - google-api-core >=3.19.5,<3.20.0 || >3.20.0,<3.20.1 || >3.20.1,<4.21.0 || >4.21.0,<4.21.1 || >4.21.1,<4.21.2 || >4.21.2,<4.21.3 || >4.21.3,<4.21.4 || >4.21.4,<4.21.5 || >4.21.5,<6.0.0.dev0
 - googleapis-common-protos >=3.20.2,<4.21.1 || >4.21.1,<4.21.2 || >4.21.2,<4.21.3 || >4.21.3,<4.21.4 || >4.21.4,<4.21.5 || >4.21.5,<6.0.0.dev0
 - grpcio-status >=4.21.6
 - proto-plus >=3.19.0,<6.0.0dev
MackHalliday commented 3 weeks ago

Picking up ticket - Since I'm out on Monday, I'll be leaving a comment at end of day Friday. @k-macmillan will be picking up the ticket if not completed.

MackHalliday commented 3 weeks ago

Unpinned protobuf - ran poetry update, everything seems OK. Did I miss something?