department-of-veterans-affairs / notification-api

Notification API
MIT License
16 stars 9 forks source link

#1953 - IIR - Integrate permission check into contact info lookup #1965

Closed stevelong00 closed 3 months ago

stevelong00 commented 3 months ago

Summary | Résumé

Currently we have two celery tasks, one for looking up contact info and one for looking up communication permissions. We want to move the permissions check into the contact info lookup so that both can use a single call to Profile API.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

  1. Enable feature flag VA_PROFILE_V3_COMBINE_CONTACT_INFO_AND_PERMISSIONS_LOOKUP
  2. Ensure that no behavior changes related to sending SMS or Email notifications
  3. Confirm via logs/Datadog that the new permissions check routine is being used. This string is logged by the new routine: V3 Profile -- Parsing Communication Permissions for

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

stevelong00 commented 3 months ago

This PR was created with the wrong template, closing and creating a new one.