Currently we have two celery tasks, one for looking up contact info and one for looking up communication permissions. We want to move the permissions check into the contact info lookup so that both can use a single call to Profile API.
Test instructions | Instructions pour tester la modification
Enable feature flag VA_PROFILE_V3_COMBINE_CONTACT_INFO_AND_PERMISSIONS_LOOKUP
Ensure that no behavior changes related to sending SMS or Email notifications
Confirm via logs/Datadog that the new permissions check routine is being used. This string is logged by the new routine: V3 Profile -- Parsing Communication Permissions for
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur
[ ] This PR does not break existing functionality.
[ ] This PR does not violate GCNotify's privacy policies.
[ ] This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
[ ] This PR does not significantly alter performance.
[ ] Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).
⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.
Summary | Résumé
Currently we have two celery tasks, one for looking up contact info and one for looking up communication permissions. We want to move the permissions check into the contact info lookup so that both can use a single call to Profile API.
Related Issues | Cartes liées
Test instructions | Instructions pour tester la modification
V3 Profile -- Parsing Communication Permissions for
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur