department-of-veterans-affairs / notification-api

Notification API
MIT License
16 stars 9 forks source link

#2054 - Added status reason to Twilio delivery status #2051

Closed k-macmillan closed 1 month ago

k-macmillan commented 1 month ago

Description

Saw many messages end up in a permanent failure or technical failure status with no status reason. This should not happen. Adjusted Twilio's delivery status to correctly fill that information in.

There was a bug with updating status_reason to None when a notification is put in the delivered status. if incoming_status_reason is not None led to it ignoring the updated status_reason. The test mocked it out and the mock has been removed.

issue #2054

How Has This Been Tested?

Updated tests. Regression passes.

Checklist