department-of-veterans-affairs / notification-api

Notification API
MIT License
16 stars 9 forks source link

502 issue: Schedule and Execute Twilio Status Updates #2058

Open k-macmillan opened 2 weeks ago

k-macmillan commented 2 weeks ago

User Story - Business Need

For any messages updates that failed to reach our servers we want to make sure we still update the status of those notifications. We wrote a function to call Twilio and update the notification with the new status, this is the ticket to find notifications that need that little update and execute it.

User Story(ies)

As a VA Notify client I want my notification status current So that I know if my notification was delivered

Additional Info and Resources

Acceptance Criteria

QA Considerations

The only way for us to e2e test this is to in some way kill our ability to receive or process the notification from Twilio. We can adjust the lambda handler code to just return and see if the cron picks it up an hour later. Using a twilio test number, it may be beneficial to test this once just to ensure it works, then fire off 500 to make sure our system can handle it and Twilio doesn't rate limit us or something. Twilio's rate limiting is not clear and most searches point to the "verify" service.

Potential Dependencies

Updating old notifications in the notification_history table.

npmartin-oddball commented 1 week ago

Hey team! Please add your planning poker estimate with Zenhub @cris-oddball @EvanParish @k-macmillan @MackHalliday @mchlwellman

mchlwellman commented 5 hours ago

I have the celery task coded and it seems to be working. Today I have to do testing and get ready for review.