After working #2019 for Prod missing SID logs, new logs started showing up in the lowers that were previously not present. This does not appear to impact the functionality of the Push notification route (a pass-through at this time). See Additional Information below for more details.
[ ] Ticket is understood, and QA has been contacted (if the ticket has a QA label).
[ ] This work is added to the sprint review slide deck (key win bullet point and demo slide)
Steps to Reproduce
Deploy main to an environment
Observe the logs described below
Workaround
We can ignore the logs, since the feature works.
Impact/Urgency
Low, but we should not have logs that indicate problems and then not handle the problem.
Expected Behavior
[ ] When I deploy to an environment, the missing SID logs should not be present
[ ] When I send a Push notification, the notification is issued.
Some considerations based on various Slack convos:
- push works. let's not forget that!
Apparently these logs only display during the migration step in the deployment
Maybe the MobileAppRegistry app is not initializing as intended in the Push notification route.
It seems to be the case that the environment variables aren't available when expected .
The value is in the s3 bucket, correctly.
The "Missing SID for app" log is gone so it's not erroring when it gets to the /_status endpoint or the Push Notifications endpoints.
This script is used for every deploy but only on the deploys that do not have the VANOTIFY_SSL_CERT_PATH variable or VANOTIFY_SSL_KEY_PATH variable available hit the log 'bypassing VAProfile cert and key file generation' and then are followed by the 'Missing environment SID' logs.
DEV yesterday at 3:46 PMPERF today at 10:52 AMAnd DEV Today at 12:51PM after I redeployed.
The 'bypassing VAProfile cert and key file generation' and the two 'Missing environment SID' logs only appear to happen once per deploy.
As far as I can tell - the two features that use the updated MobileAppRegistry class (/_status and /v2/notifications/push) are not impacted by whatever this is. Both appear to be getting the appSIDs as expected (Example - I just sent a PUSH and the sid was included) And they are not initializing the MobileAppRegistry to do so (I check the logs for the Initializing MobileAppRegistry log I added.
Description
After working #2019 for Prod
missing SID
logs, new logs started showing up in the lowers that were previously not present. This does not appear to impact the functionality of the Push notification route (a pass-through at this time). See Additional Information below for more details.Steps to Reproduce
Workaround
We can ignore the logs, since the feature works.
Impact/Urgency
Low, but we should not have logs that indicate problems and then not handle the problem.
Expected Behavior
QA Considerations
Additional Info & Resources
Screenshot of logs
Datadog link to the logs in Perf.
Some considerations based on various Slack convos:
- push works. let's not forget that!
Apparently these logs only display during the migration step in the deployment
Maybe the MobileAppRegistry app is not initializing as intended in the Push notification route.
It seems to be the case that the environment variables aren't available when expected .
The value is in the s3 bucket, correctly.
The "Missing SID for app" log is gone so it's not erroring when it gets to the /_status endpoint or the Push Notifications endpoints.
This script is used for every deploy but only on the deploys that do not have the VANOTIFY_SSL_CERT_PATH variable or VANOTIFY_SSL_KEY_PATH variable available hit the log 'bypassing VAProfile cert and key file generation' and then are followed by the 'Missing environment SID' logs. DEV yesterday at 3:46 PM PERF today at 10:52 AM And DEV Today at 12:51PM after I redeployed.
The 'bypassing VAProfile cert and key file generation' and the two 'Missing environment SID' logs only appear to happen once per deploy.
As far as I can tell - the two features that use the updated MobileAppRegistry class (/_status and /v2/notifications/push) are not impacted by whatever this is. Both appear to be getting the appSIDs as expected (Example - I just sent a PUSH and the sid was included) And they are not initializing the MobileAppRegistry to do so (I check the logs for the Initializing MobileAppRegistry log I added.