department-of-veterans-affairs / notification-api

Notification API
MIT License
16 stars 9 forks source link

#2053 - Stop Celery Chains on Expected Aborts #2116

Closed k-macmillan closed 1 week ago

k-macmillan commented 1 week ago

Description

Evaluated chains and identified which chain tasks could raise non-technical exceptions. Prevented non-technical exceptions from being raised so the Celery task does not "fail" when it has hit an expected end such as a person has opted out. This is going to help us keep an eye on actual failures.

Created documentation to help understand expected vs unexpected celery task failures.

# noqa has been added to methods that exceeded complexity thresholds. Those extra if blocks (and the noqa) will be removed by the Feature Flag cleanup ticket.

issue #2053

How Has This Been Tested?

Unit tests and deployed with a regression test passing.

Checklist