department-of-veterans-affairs / notification-utils

Notification Utils
MIT License
1 stars 0 forks source link

Utils: Update phonenumbers package 8.12.x to 8.13.x #143

Open EvanParish opened 1 year ago

EvanParish commented 1 year ago

User Story - Business Need

There is a dependabot PR (see Potential Dependencies) to update the phonenumbers package in the api repo, but first the package needs to be updated in this repo. There is a test that fails when the package is updated

User Story(ies)

As a va notify engineer I want to update dependencies So that we have an up-to-date and secure platform.

Additional Info and Resources

This is the failing test in the utils repo:

______ test_format_local_and_international_phone_numbers[+20-12-1234-1234-+20 121 234 1234] _______
[gw0] linux -- Python 3.8.16 /home/evan/.pyenv/versions/3.8.16/envs/utils-venv/bin/python3.8

phone_number = '+20-12-1234-1234', expected_formatted = '+20 121 234 1234'

>   ???
E   AssertionError: assert '+20 12 12341234' == '+20 121 234 1234'
E     - +20 121 234 1234
E     + +20 12 12341234

/home/evan/dev/va/notification-utils/tests/test_recipient_validation.py:419: AssertionError
===== short test summary info =====
FAILED tests/test_recipient_validation.py::test_format_local_and_international_phone_numbers[+20-12-1234-1234-+20 121 234 1234] - AssertionError: assert '+20 12 12341234' == '+20 121 234 1234'
===== 1 failed, 1364 passed, 76 skipped, 41 xfailed

Engineering Checklist

Acceptance Criteria

QA Considerations

Potential Dependencies

This is necessary to clear this dependabot PR for the api repo.

mjones-oddball commented 1 year ago

Hey team! Please add your planning poker estimate with Zenhub @babyjunior56 @cris-oddball @EvanParish @k-macmillan @kalbfled @ldraney @nikolai-efimov

npmartin-oddball commented 3 weeks ago

Still needed.

cris-oddball commented 2 weeks ago

No more dependabot issues, probably because dependabot doesn't look in the utils setup.py. Still needed.