I was able to convert the NotificationRequest interface to an abstract class, so that there is less duplication between SmsRequest and EmailRequest.
That required a heavy usage of generics for the builders to work.
Please take a look and see if it's ok to merge.
We can also decide that it's too confusing and accept a little duplication.
I was able to convert the NotificationRequest interface to an abstract class, so that there is less duplication between SmsRequest and EmailRequest. That required a heavy usage of generics for the builders to work. Please take a look and see if it's ok to merge. We can also decide that it's too confusing and accept a little duplication.