search

department-of-veterans-affairs / notifications-java-client

VA Notify Java Client
https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/va-notify
MIT License
1 stars 0 forks source link

Convert NotificationRequest interface to an abstract class to limit duplication of code. #1

Closed ffafara-tw closed 3 years ago

ffafara-tw commented 3 years ago

I was able to convert the NotificationRequest interface to an abstract class, so that there is less duplication between SmsRequest and EmailRequest. That required a heavy usage of generics for the builders to work. Please take a look and see if it's ok to merge. We can also decide that it's too confusing and accept a little duplication.