search

department-of-veterans-affairs / roadrunner-rails

Base rails project with the VA special sauce.
Other
7 stars 6 forks source link

Add committing early to instructions for setting up your project #35

Open ayaleloehr opened 8 years ago

ayaleloehr commented 8 years ago

I made the mistake of not committing to my repo right away when starting the facility locator. This is now making a first commit daunting for code review because I will have to specify which parts I wrote and which parts come from roadrunner. Not ideal. We should strongly suggest future users of this commit to their project right away to get the basics out of the way and save them from following in my footsteps.

shanear commented 8 years ago

The setup script should have made a first commit for you. Like this one:

https://github.com/department-of-veterans-affairs/caseflow-certification/commit/f65b3bf6e7647905564f5828ca2c0c64e6d0a36a

Did that not happen? or is that not what you're talking about?

ayaleloehr commented 8 years ago

Sorry for the delay. That's exactly what I'm talking about! That seems not to have happened on mine.

@shanear Does it make that commit directly to master? And does it just commit locally or should it automatically go to Github as well? One thought is that there were already some files in the repo I was creating, could that have thrown it off?