department-of-veterans-affairs / roadrunner

Other
2 stars 5 forks source link

src change - for gh-pages #83

Closed emilyville closed 8 years ago

emilyville commented 8 years ago
webinista commented 8 years ago

Looks like one of the default posts is missing a valid date in the YAML front matter, so Jekyll can't build the site. There are also some merge conflicts.

@awong-dev I tried merging, but this appears to delete everything. Do you have time to take a look?

awong-dev commented 8 years ago

Gha... @webinista I completely missed this. If you assign me a PR, can you possibly ping me on slack? I get so many github notifications, I have a tendency to miss these. If you haven't seen anything from me in like an hour, you can be pretty sure it's been lost. :(

I'll try to get better at watching my assigned queue, but always feel free to pester if I'm not responding.

emilyville commented 8 years ago

ok @webinista or @awong-dev all green again!

emilyville commented 8 years ago

Made the footer link correct instead of just #. :)

emilyville commented 8 years ago

Removed the "roadrunner" baseurl from the url to fix the external link html proofer tests.

awong-dev commented 8 years ago

@emilyville back at ya.

awong-dev commented 8 years ago

LGTM w/o caveat.

I'm still uncertain about destination: ./_site/roadrunner but this PR has been outstanding too long and it's less harmful to have that possible mistake checked in than leaving it open.