department-of-veterans-affairs / tmf-auth-exp-design-patterns

Developing design patterns for the authenticated experience
2 stars 0 forks source link

Create Storybook Components for Prefill Pattern in VADS Guidance [stretch goal] #120

Closed bellepx0 closed 1 month ago

bellepx0 commented 2 months ago

Develop Storybook components for the prefill pattern to be included in the VADS guidance documentation.

  1. Create “Patterns” Folder in VADS Storybook
    • Main parent folder: Prefill
    • Two sub-folders: Components and Usage Examples
  2. Components to be Created: a) Prefill Alert Component -> Three variations:
    • Unauthenticated Alert
    • Prefilled Info Alert
    • Signed In Alert b) Locked Gray Card Component c) Unlockable White Card with Border Component 3) Usage Examples --> Mock form samples demonstrating how each component is to be integrated into the form

**Keep in mind for following ticket: how and where to share the Storybook components. Potential places include the VA Forms Library docs and the Form Digitization Development Guide.

Acceptance Criteria:

bellepx0 commented 1 month ago

Created draft PR for Matt to review and get team feedback

bellepx0 commented 1 month ago

Update: Moved the PR out of draft. Tagged Matt as a reviewer letting him know we'd like his feedback. Also added the PR link to the collab cycle ticket under "Staging Review" > "Staging review artifacts" > "Required Artifacts".

beckyphung commented 1 month ago

@msbtterswrth Can we make sure to align on the same names of things across all of the different artifacts we're creating. For example, in our GitHub draft for the "Know when their information is prefilled" page, we use editable and uneditable to describe the types of cards.

In the storybook, I see we're using locked and unlocked. Editable and uneditable imo is clearer.

msbtterswrth commented 1 month ago

CC @bellepx0 if we could update that please

bellepx0 commented 1 month ago

@beckyphung @msbtterswrth Updated all instances of locked and unlocked to editable and uneditable respectively.