department-of-veterans-affairs / tmf-auth-exp-design-patterns

Developing design patterns for the authenticated experience
2 stars 0 forks source link

FE - Prefill Pattern Task Updates - Post Pilot Fixes #86

Closed adamwhitlock1 closed 2 weeks ago

adamwhitlock1 commented 3 weeks ago

User Story

As an engineer I would like to update a few small bugs and issues with the current state out our current pilot task prototypes.

General

Green Task

Yellow Task

Purple Task

Background

After pilot we found these issues, so we want to update our code to fix them.

ACs

adamwhitlock1 commented 3 weeks ago

We can split this up if we want, but thought we should get all these items in a hit list to knock out.

msbtterswrth commented 3 weeks ago

@adamwhitlock1 i've added this to the sprint, could you point this and lmk when you think it might be done?

adamwhitlock1 commented 3 weeks ago

We have pointed it for an estimate of 3 since we have several things to tackle and a few things have been tripping us up with the logic around the save logic. We should be done with this by the end of the sprint. Adam is working on the navigation page #84 next, but will be focusing on updates around this ticket for green/yellow once that is done, and Belle has already started working on the purple updates.

adamwhitlock1 commented 3 weeks ago

Updates have been addressed in Belle's PR: https://github.com/department-of-veterans-affairs/vets-website/pull/31430 for the purple task.

Updates for the green and yellow tasks are made in this PR from Adam: https://github.com/department-of-veterans-affairs/vets-website/pull/31483 along with the navigation page. Once these PRs are approved and merged, then we will review the latest changes with the team.

adamwhitlock1 commented 3 weeks ago

We have merged these fixes and deployed a new codespace.

I had to change the url of the codespace, because the old codespace would throttle down after 30 minutes of inactivity, even though I had updated the settings to be 4 hours instead. The reason for this is that the codespace was created before I updated that setting, and so I had to destroy it / make a new one with a new url for the new setting to take. From here on out that should no longer be an issue.

https://musical-doodle-7676579pxr3rxrg-3001.app.github.dev/mock-form-ae-design-patterns

This task is ready to be reviewed and validated / closed as time permits.

msbtterswrth commented 2 weeks ago

Everything looked great to me on our qa call yesterday! I'll close this and we can open a new task if we find anything else, great job team!