Closed taylorkaren closed 2 years ago
Two PRs on this issue:
This one was closed without merging the commits because the ticket went stale: https://github.com/department-of-veterans-affairs/vets-website/pull/19085/fil](https://github.com/department-of-veterans-affairs/vets-website/pull/19085/files
This one is ready for review: https://github.com/department-of-veterans-affairs/vets-website/pull/19085/files
@taylorkaren @nickjg231, I started work on this yesterday and just made a draft PR for it: https://github.com/department-of-veterans-affairs/vets-website/pull/21504
I remember assigning myself this ticket, moving it to In Progress, and setting the sprint. However, Zenhub must have been lagging for me at the time, and none of my changes were set.
Anish is reaching out to Robin Garrison for assistance with this ticket.
Hey @micahchiang, I think my PR may be failing due to tests that are not related to the code I updated. What would be next steps here? Link to PR
Error messages are now announced when tabbing through fields:
One feature that was not added is the aria-invalid
attribute on the input field. Adding this feature to the current forms library is a major effort, as the TextWidget component is tied with so many other components. I propose that we do not retrofit this feature into the current forms library, but instead add the feature to the new VFSC.
The new ticket has been created here: https://app.zenhub.com/workspaces/forms-library---platform-spike-team-61b0ae1f2cd3c30014e8a5b0/issues/department-of-veterans-affairs/va-forms-system-core/476
cc @micahchiang @taylorkaren @joshkimux
KT Addendum: Add aria-invalid to most form components is being handled on ticket department-of-veterans-affairs/component-library#489, not the ticket referenced above.
ORIGINAL TICKET: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/414
@joshkimux commented on Wed Mar 31 2021
Bug Report
This is related to handling IE11 + JAWS reading errors twice in #314
What happened
Errors are currently not announced to screen reader users while in forms mode (navigating by tab). This is because they aren't programmatically linked to their respective fields (either by including them in the
Originally documented in #22298 along with a recommended solution.
What I expected to happen
Proposed fix
Current
Suggested
Reproducing
Steps to reproduce:
https://user-images.githubusercontent.com/14154792/112867965-83bc3100-9089-11eb-866f-7c313a02b93c.mov
@joshkimux commented on Wed Mar 31 2021
@1Copenut for awareness
@1Copenut commented on Wed Mar 31 2021
Thank you @joshkimux!
@noahgelman commented on Mon Aug 30 2021
This is in PR https://github.com/department-of-veterans-affairs/vets-website/pull/18430
@noahgelman commented on Tue Oct 26 2021
Waiting on approval. Build is currently failing due to a failure in the VAFacilityPage component.
@k80bowman commented on Thu Jan 13 2022
@noahgelman just checking in. Is this something you might be able to get back to soon?
@noahgelman commented on Fri Jan 14 2022
Yes, I was just looking at it yesterday.
On Thu, Jan 13, 2022 at 3:30 PM Katy Bowman @.***> wrote:
@noahgelman commented on Mon Jan 24 2022
@ddzz Can you review this PR? https://github.com/department-of-veterans-affairs/vets-website/pull/19085/files