department-of-veterans-affairs / va-forms-system-core

VA Forms System Core will be a React library hosted in NPM that will allow engineers and designers to easily interact with Forms inside of vets-website.
https://department-of-veterans-affairs.github.io/va-forms-system-core/
6 stars 4 forks source link

Feat/495 add change handler to text field #497

Closed adamwhitlock1 closed 2 years ago

adamwhitlock1 commented 2 years ago

Description

Adds an onValueChange prop to the TextField component to allow for a function to be passed for handling value change events. The existing Formik field.onChange would still fire but the additional function prop could also be called if it is provided.

Original issue(s)

https://github.com/department-of-veterans-affairs/va-forms-system-core/issues/495

Testing done

Added a unit test for this new prop

Definition of done

obliviga commented 2 years ago

LGTM, we really appreciate your contribution! One suggestion I have is to update the link's text of the original issue in the PR description, so shows 495 instead of 0000. @adamwhitlock1

va-vsp-bot commented 2 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: