Fix buttons on Page & update skipped tests

bkjohnson commented 2 years ago

Description

Changes from https://github.com/department-of-veterans-affairs/va-forms-system-core/pull/508 caused markup changes which broke some tests, and those failing tests were skipped. This updates the 4 skipped tests so that they can run again. This also has some changes which fix the way the button components are rendered on <Page>.

I also found test for Chapter that was skipped before <VaButton> was used and updated that to pass as well.

Original issue(s)

N/A

Testing done

Unit tests

Screenshots

Definition of done

[ ] Documentation has been updated, if applicable
[ ] A link to the original github issue has been provided
[ ] No sensitive information (i.e. PII/credentials/internal URLs etc.) is captured in logging, hardcoded, or specs

bjmccotter7192 commented 2 years ago

@bkjohnson Nice! Thanks for this PR

va-vsp-bot commented 2 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

department-of-veterans-affairs / va-forms-system-core