VA Forms System Core [Demo Content]: Component choice - select vs. text input

[TiffanyPender]

• 508-defect-4: ✔️Trivial. Consider fixing or exploring in 2-4 sprints post-launch

User Story or Problem Statement

As a user with cognitive issues, it is helpful when simplified choices are made available for form fields that have pre-defined options available.

Details

This may be more to do with form content than the library, but worth documenting - within the Forms Library Core demo form, on step 4: Military Service History, the Branch of Service field is a text input, but could be a select element since there are only a small number of choices available.

Acceptance Criteria

• [ ] Branch of Service field is a select element with available branches of service as dropdown options

Environment

• macOS Monterey, <Version 12.4>
• Chrome, <Version 102.0.5005.61>
• VoiceOver
• Staging

Steps to Recreate

1. Visit the Forms Library Core demo form
2. Navigate to step 4: Military Service History
3. Verify that Branch of Service field is a text field, not a select field element

[taylorkaren]

The Branch of Service field is a text input on the demo form because that is how it is implemented on the production form that we used as the source and model for the demo form, so that was a form content choice made by team that built the "real" form.

But having said that, we are trying to model good form building accessibility practices, so I think we should go ahead and make this change. The options to include in the select field would be (from What Are the Branches of the US Military?):

• Air Force
• Army
• Coast Guard
• Marine Corps
• Navy
• Space Force

[obliviga]

PR is ready for review: https://github.com/department-of-veterans-affairs/va-forms-system-core/pull/566

[obliviga]

Moving this back to In Progress, as the change needs to be applied to the demo in the vets-website repo.

[obliviga]

Verified fix has been deployed: