238 array field - Githubissues

department-of-veterans-affairs / va-forms-system-core

VA Forms System Core will be a React library hosted in NPM that will allow engineers and designers to easily interact with Forms inside of vets-website.

https://department-of-veterans-affairs.github.io/va-forms-system-core/

6 stars 4 forks source link

238 array field #574

Closed micahchiang closed 2 years ago

micahchiang commented 2 years ago

Description

This pull request adds support for array fields in VAFSC

Original issue(s)

department-of-veterans-affairs/va-forms-system-core#238

Testing done

Screenshots

Definition of done

[ ] Package.json version has been updated to match Github release tag
[ ] Documentation has been updated, if applicable
[x] A link to the original github issue has been provided
[x] No sensitive information (i.e. PII/credentials/internal URLs etc.) is captured in logging, hardcoded, or specs

nickjg231 commented 2 years ago

Some of our React library packages were downgraded for the time being because of a dependency issue with the <FieldArray> element:

larsmaxwell commented 2 years ago

Some of our React library packages were downgraded for the time being because of a dependency issue with the <FieldArray> element:

@nickjg231 would double check with @bjmccotter7192 that this isn't going to cause any issues when pulled into vets website

bjmccotter7192 commented 2 years ago

Some of our React library packages were downgraded for the time being because of a dependency issue with the <FieldArray> element:

@nickjg231 would double check with @bjmccotter7192 that this isn't going to cause any issues when pulled into vets website

So in vets-website they use 17.0.2 on those packages so is there a way to match the types to 17.0.2?

micahchiang commented 2 years ago

Some of our React library packages were downgraded for the time being because of a dependency issue with the <FieldArray> element:

@nickjg231 would double check with @bjmccotter7192 that this isn't going to cause any issues when pulled into vets website

So in vets-website they use 17.0.2 on those packages so is there a way to match the types to 17.0.2?

This might not actually resolve the FieldArray build error, so this change may be removed from the PR. Doing a little more research into it.