department-of-veterans-affairs / va-forms-system-core

VA Forms System Core will be a React library hosted in NPM that will allow engineers and designers to easily interact with Forms inside of vets-website.
https://department-of-veterans-affairs.github.io/va-forms-system-core/
6 stars 4 forks source link

feat(531) pass custom func on onChange #597

Closed harshil1793 closed 2 years ago

harshil1793 commented 2 years ago

Description

Adds an onValueChange prop to the NumberField, SelectField, RadioField, EmailField, DateField, CheckboxField component to allow for a function to be passed for handling value change events. The existing Formik field.onChange would still fire but the additional function prop could also be called if it is provided.

Original issue(s)

department-of-veterans-affairs/va-forms-system-core#531

Testing done

Screenshots

Definition of done

bjmccotter7192 commented 2 years ago

Is this going to be a feat or a fix? Because the title has feat but the version was bumped for a fix.

va-vsp-bot commented 2 years ago

:tada: This PR is included in version 1.4.6 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: