department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

CU/9849-TKD-detox-Nav-bytext-removal #10156

Closed TKDickson closed 1 week ago

TKDickson commented 1 week ago

Description of Change

Despite the name of the branch (not enough caffeine this morning), this PR is actually to remove by.text methods (where possible) from the Navigation.e2e.ts file, and replace them with by.id.

Not a lot that I thought was feasible, but I replaced the few I could. Those were all IDs in other scripts already, so moved to utils and replaced by the common constant in all scripts needed.

Closes #9849

Screenshots/Video

Testing

Passing iOS Passing Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

For QA

Run a build for this branch